Skip to content

Commit e5bad6c

Browse files
authored
Carousel - remove references to migrate (#1007)
1 parent 3f432aa commit e5bad6c

File tree

2 files changed

+23
-23
lines changed

2 files changed

+23
-23
lines changed

src/components/carousel/__tests__/CarouselPresenter.spec.js

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2,46 +2,46 @@ import * as uut from '../CarouselPresenter';
22

33
describe('Carousel presenter', () => {
44
it('should getChildrenLength', () => {
5-
expect(uut.getChildrenLength({migrate: true, children: [{}, {}, {}]})).toBe(3);
6-
expect(uut.getChildrenLength({migrate: true, children: [{}]})).toBe(1);
7-
expect(uut.getChildrenLength({migrate: true})).toBe(0);
5+
expect(uut.getChildrenLength({children: [{}, {}, {}]})).toBe(3);
6+
expect(uut.getChildrenLength({children: [{}]})).toBe(1);
7+
expect(uut.getChildrenLength()).toBe(0);
88
});
99

1010
describe('calcOffset', () => {
1111
it('should calcOffset (default mode)', () => {
12-
expect(uut.calcOffset({migrate: true, children: [{}, {}, {}]}, {pageWidth: 120, currentPage: 0})).toBe(0);
13-
expect(uut.calcOffset({migrate: true, children: [{}, {}, {}]}, {pageWidth: 120, currentPage: 1})).toBe(120);
14-
expect(uut.calcOffset({migrate: true, children: [{}, {}, {}]}, {pageWidth: 120, currentPage: 2})).toBe(240);
12+
expect(uut.calcOffset({children: [{}, {}, {}]}, {pageWidth: 120, currentPage: 0})).toBe(0);
13+
expect(uut.calcOffset({children: [{}, {}, {}]}, {pageWidth: 120, currentPage: 1})).toBe(120);
14+
expect(uut.calcOffset({children: [{}, {}, {}]}, {pageWidth: 120, currentPage: 2})).toBe(240);
1515
});
1616

1717
it('should calcOffset (loop mode)', () => {
18-
expect(uut.calcOffset({migrate: true, loop: true, children: [{}, {}, {}]}, {pageWidth: 120, currentPage: 0})).toBe(120);
19-
expect(uut.calcOffset({migrate: true, loop: true, children: [{}, {}, {}]}, {pageWidth: 120, currentPage: 1})).toBe(240);
20-
expect(uut.calcOffset({migrate: true, loop: true, children: [{}, {}, {}]}, {pageWidth: 120, currentPage: 2})).toBe(360);
18+
expect(uut.calcOffset({loop: true, children: [{}, {}, {}]}, {pageWidth: 120, currentPage: 0})).toBe(120);
19+
expect(uut.calcOffset({loop: true, children: [{}, {}, {}]}, {pageWidth: 120, currentPage: 1})).toBe(240);
20+
expect(uut.calcOffset({loop: true, children: [{}, {}, {}]}, {pageWidth: 120, currentPage: 2})).toBe(360);
2121
});
2222
});
2323

2424
describe('calcPageIndex', () => {
2525
it('should calcPageIndex', () => {
26-
expect(uut.calcPageIndex(120, {migrate: true, children: [{}, {}, {}]}, 120)).toBe(1);
27-
expect(uut.calcPageIndex(245, {migrate: true, children: [{}, {}, {}]}, 120)).toBe(2);
28-
expect(uut.calcPageIndex(481, {migrate: true, children: [{}, {}, {}]}, 120)).toBe(2);
29-
expect(uut.calcPageIndex(5, {migrate: true, children: [{}, {}, {}]}, 120)).toBe(0);
26+
expect(uut.calcPageIndex(120, {children: [{}, {}, {}]}, 120)).toBe(1);
27+
expect(uut.calcPageIndex(245, {children: [{}, {}, {}]}, 120)).toBe(2);
28+
expect(uut.calcPageIndex(481, {children: [{}, {}, {}]}, 120)).toBe(2);
29+
expect(uut.calcPageIndex(5, {children: [{}, {}, {}]}, 120)).toBe(0);
3030
});
3131

3232
it('should calcPageIndex (loop mode)', () => {
33-
expect(uut.calcPageIndex(120, {migrate: true, loop: true, children: [{}, {}, {}]}, 120)).toBe(0);
34-
expect(uut.calcPageIndex(245, {migrate: true, loop: true, children: [{}, {}, {}]}, 120)).toBe(1);
35-
expect(uut.calcPageIndex(481, {migrate: true, loop: true, children: [{}, {}, {}]}, 120)).toBe(0);
36-
expect(uut.calcPageIndex(5, {migrate: true, loop: true, children: [{}, {}, {}]}, 120)).toBe(2);
33+
expect(uut.calcPageIndex(120, {loop: true, children: [{}, {}, {}]}, 120)).toBe(0);
34+
expect(uut.calcPageIndex(245, {loop: true, children: [{}, {}, {}]}, 120)).toBe(1);
35+
expect(uut.calcPageIndex(481, {loop: true, children: [{}, {}, {}]}, 120)).toBe(0);
36+
expect(uut.calcPageIndex(5, {loop: true, children: [{}, {}, {}]}, 120)).toBe(2);
3737
});
3838
});
3939

4040
it('should return isOutsideLimits', () => {
41-
expect(uut.isOutOfBounds(120, {migrate: true, children: [{}, {}, {}]}, 120)).toBe(false);
42-
expect(uut.isOutOfBounds(1125, {migrate: true, children: [{}, {}, {}, {}]}, 375)).toBe(false);
43-
expect(uut.isOutOfBounds(0, {migrate: true, children: [{}, {}, {}]}, 120)).toBe(true);
44-
expect(uut.isOutOfBounds(481, {migrate: true, children: [{}, {}, {}]}, 120)).toBe(true);
45-
expect(uut.isOutOfBounds(1875, {migrate: true, children: [{}, {}, {}, {}]}, 375)).toBe(true);
41+
expect(uut.isOutOfBounds(120, {children: [{}, {}, {}]}, 120)).toBe(false);
42+
expect(uut.isOutOfBounds(1125, {children: [{}, {}, {}, {}]}, 375)).toBe(false);
43+
expect(uut.isOutOfBounds(0, {children: [{}, {}, {}]}, 120)).toBe(true);
44+
expect(uut.isOutOfBounds(481, {children: [{}, {}, {}]}, 120)).toBe(true);
45+
expect(uut.isOutOfBounds(1875, {children: [{}, {}, {}, {}]}, 375)).toBe(true);
4646
});
4747
});

src/components/colorPicker/ColorPalette.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ export default class ColorPalette extends PureBaseComponent {
329329

330330
return (
331331
<View center style={[containerStyle, styles.paginationContainer]}>
332-
<Carousel migrate loop={loop} onChangePage={this.onChangePage} ref={this.carousel}>
332+
<Carousel loop={loop} onChangePage={this.onChangePage} ref={this.carousel}>
333333
{_.map(colorGroups, (colorsPerPage, index) => {
334334
return this.renderPalette(others, {...styles.page, width: this.containerWidth}, colorsPerPage, index);
335335
})}

0 commit comments

Comments
 (0)