revert change of omitting empty values from modifiers due to UI layout issues

ethanshar · ethanshar · commit f41ab8044cc7 · 2020-06-08T16:29:15.000+03:00
diff --git a/src/commons/modifiers.ts b/src/commons/modifiers.ts
@@ -364,8 +364,10 @@ export function generateModifiersStyle(options = {
     style.positionStyle = extractPositionStyle(boundProps);
   }
 
+  return style;
   // clean empty objects and undefined
-  return _.omitBy(style, value => _.isUndefined(value) || (_.isPlainObject(value) && _.isEmpty(value))); 
+  // (!) This change is currently breaking UI layout for some reason - worth investigating
+  // return _.omitBy(style, value => _.isUndefined(value) || (_.isPlainObject(value) && _.isEmpty(value))); 
 }
 
 export function getAlteredModifiersOptions(currentProps: any, nextProps: any) {

Original file line number	Diff line number	Diff line change
`@@ -364,8 +364,10 @@ export function generateModifiersStyle(options = {`
`364`	`364`	`style.positionStyle = extractPositionStyle(boundProps);`
`365`	`365`	`}`
`366`	`366`
	`367`	`+ return style;`
`367`	`368`	`// clean empty objects and undefined`
`368`		`- return _.omitBy(style, value => _.isUndefined(value) \|\| (_.isPlainObject(value) && _.isEmpty(value)));`
	`369`	`+ // (!) This change is currently breaking UI layout for some reason - worth investigating`
	`370`	`+ // return _.omitBy(style, value => _.isUndefined(value) \|\| (_.isPlainObject(value) && _.isEmpty(value)));`
`369`	`371`	`}`
`370`	`372`
`371`	`373`	`export function getAlteredModifiersOptions(currentProps: any, nextProps: any) {`