Fix/drawer types source #1069
Merged
Fix/drawer types source #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Dec 13, 2020
generatedTypes/index.d.ts
Outdated
| @@ -35,6 +35,7 @@ export {default as TouchableOpacity, TouchableOpacityProps} from './components/t | |||
| export {default as Button, ButtonPropTypes, ButtonProps} from './components/button'; | |||
| export {default as Checkbox, CheckboxPropTypes, CheckboxProps} from './components/checkbox'; | |||
| export {default as Chip, ChipPropTypes, ChipProps} from './components/chip'; | |||
| export {default as Drawer, DrawerProps, ItemProps} from './components/drawer'; | |||
There was a problem hiding this comment.
We can't export a typing called ItemProps it's too vague.
Better rename it to DrawerItemProps
| @@ -67,7 +68,6 @@ export {default as Carousel, CarouselProps} from './components/carousel'; | |||
| export { | |||
| ActionSheet, | |||
| ConnectionStatusBar, | |||
| Drawer, | |||
There was a problem hiding this comment.
Make sure to update the exports also in src/index.ts file
ethanshar
approved these changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing Drawer's manual typings and fixing generated types.
Adding 'customValue' prop to pass along from user to component and back on component's events.
Declaring props.
Changelog
Drawer - Removing Drawer's manual typings and fixing generated types. Adding 'customValue' prop to pass along from user to component and back on component's events. Declaring missing props.