Fix Incubator TextField placeholder's disabled color #2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Apr 24, 2022
src/incubator/TextField/types.ts
Outdated
| @@ -215,7 +215,7 @@ export type TextFieldProps = MarginModifiers & | |||
| }; | |||
|
|
|||
| export type InternalTextFieldProps = PropsWithChildren< | |||
| TextFieldProps & BaseComponentInjectedProps & ForwardRefInjectedProps | |||
| TextFieldProps & BaseComponentInjectedProps & ForwardRefInjectedProps & {placeholderColor: ColorType} | |||
There was a problem hiding this comment.
Shouldn't we add the placeholderColor type to TextFieldProps with the rest of the props?
There was a problem hiding this comment.
Found the correct prop: placeholderTextColor, already there :)
ethanshar
reviewed
Apr 25, 2022
| @@ -7,6 +7,13 @@ const colorByState = { | |||
| disabled: Colors.$textDisabled | |||
| }; | |||
|
|
|||
| const placeHolderTextColorByState = { | |||
There was a problem hiding this comment.
Suggested change
| const placeHolderTextColorByState = { | |
| const placeholderTextColorByState = { |
| @@ -128,7 +128,7 @@ const TextField = (props: InternalTextFieldProps) => { | |||
| )} | |||
| {children || ( | |||
| <Input | |||
| placeholderTextColor={hidePlaceholder ? 'transparent' : Colors.$textNeutral} | |||
| placeholderTextColor={hidePlaceholder ? 'transparent' : placeholderTextColor} | |||
There was a problem hiding this comment.
technically you're replacing the default value with undefined, no?
There was a problem hiding this comment.
No, I am changing the default for a non-floating placeholder from a string (set here to: Colors.$textNeutral) to an object (set in default.ts->placeholderTextColorByState); and this way I can set the disabled type to look like it's disabled: Colors.$textDisabled
ethanshar
approved these changes
Apr 25, 2022
M-i-k-e-l
deleted the
fix/incubator-text-field-placeholder-disabled-color
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Incubator TextField placeholder's disabled color (when floating is also disabled).
There are 4 examples below, the 4th has a wrong color for the placeholder, this happens when both
floatingPlaceholder={false}andeditable={false}.Snippet:
Changelog
Fix Incubator TextField placeholder's disabled color (when floating is also disabled).