#26 - Expose Refresh Token in Authenticated REST API requests #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- This exposes `X-JWT-Refresh` in the repsonse headers of REST API requests that were authenticated with a WPGraphQL issued JWT Auth Token. You can see this in action in the below GIF where I: - Login via GraphQL to get an authToken - Use the authToken as my Authorizaton token in a WP REST API request - See a `X-JWT-Refresh` token in the REST API response headers 
--- Code review update. . .only expose for SSL requests _or_ for GRAPHQL_DEBUG requests
CodeProKid
requested changes
Feb 19, 2019
src/ManageTokens.php
Outdated
| * If the request _is_ SSL, or GRAPHQL_DEBUG is defined, return the tokens | ||
| * otherwise do not return them. | ||
| */ | ||
| if ( is_ssl() || defined( 'GRAPHQL_DEBUG' ) && true !== GRAPHQL_DEBUG ) { |
There was a problem hiding this comment.
Suggested change
| if ( is_ssl() || defined( 'GRAPHQL_DEBUG' ) && true !== GRAPHQL_DEBUG ) { | |
| if ( ( ! defined( 'GRAPHQL_DEBUG' ) || true !== GRAPHQL_DEBUG ) && ! is_ssl() ) { |
- code review updates
CodeProKid
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes
X-JWT-Refreshin the repsonse headers of REST API requests that were authenticated with a WPGraphQL issued JWT Auth Token.You can see this in action in the below GIF where I:
X-JWT-Refreshtoken in the REST API response headers