Skip to content

Commit d38391b

Browse files
committed
revert test_loc_setitem_consistency_empty test case after pandas-dev#49775
1 parent aff0060 commit d38391b

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

pandas/tests/indexing/test_indexing.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -633,11 +633,11 @@ def test_index_type_coercion(self, indexer):
633633

634634
def test_setitem_one_element_list(self):
635635
# GH#52825
636-
texts = ["abc"]
637-
languages = ["en"]
638-
df = DataFrame(columns=["text", "language"])
639-
df.loc[:, "text"] = texts
640-
df.loc[:, "language"] = languages
636+
x_values = ["x_value"]
637+
y_values = ["y_values"]
638+
df = DataFrame(columns=["x", "y"])
639+
df.loc[:, "x"] = x_values
640+
df.loc[:, "y"] = y_values
641641
assert df.size == 2
642642

643643

pandas/tests/indexing/test_loc.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -614,18 +614,15 @@ def test_loc_setitem_consistency_single_row(self):
614614

615615
def test_loc_setitem_consistency_empty(self):
616616
# empty (essentially noops)
617-
# before the enforcement of #45333 in 2.0, the loc.setitem here would
618-
# change the dtype of df.x to int64
619617
expected = DataFrame(columns=["x", "y"])
618+
expected["x"] = expected["x"].astype(np.int64)
620619
df = DataFrame(columns=["x", "y"])
621620
with tm.assert_produces_warning(None):
622621
df.loc[:, "x"] = 1
623622
tm.assert_frame_equal(df, expected)
624623

625-
# setting with setitem swaps in a new array, so changes the dtype
626624
df = DataFrame(columns=["x", "y"])
627625
df["x"] = 1
628-
expected["x"] = expected["x"].astype(np.int64)
629626
tm.assert_frame_equal(df, expected)
630627

631628
def test_loc_setitem_consistency_slice_column_len(self):

0 commit comments

Comments
 (0)