You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would be willing to do a PR for this to implement the Illuminate\Contracts\View\View to make this more consistent with the Laravel framework.
Code snippet of problem
Details are above but as a Laravel user I would expect DataTables->with() to follow along with the View contract method and allow passing of objects and other types.
System details
Operating System: MacOS 12.6
PHP Version: 8.1.10
Laravel Version: Laravel 9.31.0
Laravel-DataTables Version: Started with 9.0.0 but running 9.0.10
The text was updated successfully, but these errors were encountered:
Summary of problem or feature request
When version 9.0.0 was released you added more parameter typehints, https://github.com/yajra/laravel-datatables-buttons/blob/master/src/Services/DataTable.php#L688 was changed to only allow
array|string|null
as a value when it should have stayed asmixed
in the docblock to conform with the View contract https://github.com/laravel/framework/blob/9.x/src/Illuminate/Contracts/View/View.php#L23I would be willing to do a PR for this to implement the
Illuminate\Contracts\View\View
to make this more consistent with the Laravel framework.Code snippet of problem
Details are above but as a Laravel user I would expect DataTables->with() to follow along with the View contract method and allow passing of objects and other types.
System details
The text was updated successfully, but these errors were encountered: