You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
## What's the problem this PR addresses?
Proxying with the `tunnel` package is... finnicky. I did not extensively
investigate these but as a few examples of issues I encountered when I
used it in the past:
- Does not use the specified CA certificates, even for HTTPS over HTTP
proxy
- Does not use proxy after redirects
Fixes#6568Fixes#5244
Hard to tell definitively without reproductions but these should be also
fixed:
Fixes#3215Fixes#2250
## How did you fix it?
Use `hpagent` instead. This by itself fixes most HTTPS over HTTP
proxying issues.
I have also reused HTTPS network settings (e.g. CA certs) for connecting
to HTTPS proxies.
Side note: `pem` needs openssl installed to work which makes testing
this (and running other HTTPS-related test) difficult in some cases
(e.g. on Windows). Should we use another library for HTTPS testing?
## Checklist
<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).
<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [x] I have set the packages that need to be released for my changes to
be effective.
<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.
---------
Co-authored-by: Maël Nison <[email protected]>
0 commit comments