Skip to content

Commit 0537427

Browse files
committed
Fix basic account and network rule test cases
1 parent 256e8b3 commit 0537427

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

src/Storage/RegressionTests/srp.ps1

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ Describe "Management plan test" {
5252
$result.NameAvailable | should -Be $false
5353

5454
$account = Get-AzStorageAccount -ResourceGroupName $rgname -StorageAccountName $accountNameBasic | Set-AzStorageAccount -EnableHttpsTrafficOnly $false -AccessTier cool -Force
55-
$account.EnableHttpsTrafficOnly | should -Be $false
55+
# $account.EnableHttpsTrafficOnly | should -Be $false -- comment out the check since EnableHttpsTrafficOnly is always true
5656
$account.AccessTier | should -Be "Cool"
5757
$account = Get-AzStorageAccount -ResourceGroupName $rgname -StorageAccountName $accountNameBasic | Set-AzStorageAccount -UpgradeToStorageV2 -PublicNetworkAccess Enabled -AllowedCopyScope PrivateLink
5858
$account.Kind | should -Be "StorageV2"
@@ -238,15 +238,18 @@ Describe "Management plan test" {
238238
New-AzStorageAccount -ResourceGroupName $rgname -Name $accountNameNetRule1 -SkuName Standard_LRS -Location eastus
239239
New-AzStorageAccount -ResourceGroupName $rgname -Name $accountNameNetRule2 -SkuName Standard_LRS -Location eastus
240240

241+
$resourceId1 = "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/myResourceGroup/providers/Microsoft.DataFactory/factories/myDataFactory"
242+
$resourceId2 = "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/myResourceGroup/providers/Microsoft.Sql/servers/mySQLServer"
243+
241244
#Update the Account NetworkACL with JSON
242245
echo "Update the Account NetworkACL with JSON"
243246
$rule = Update-AzStorageAccountNetworkRuleSet -ResourceGroupName $rgname -Name $accountNameNetRule1 -Bypass AzureServices -DefaultAction Allow -IpRule (@{IPAddressOrRange="20.11.0.0/16";Action="allow"},
244247
@{IPAddressOrRange="28.0.2.0/19";Action="allow"},
245248
@{IPAddressOrRange="129.0.2.34/25";Action="allow"})`
246249
-VirtualNetworkRule (@{VirtualNetworkResourceId=$vnet1;Action="allow"},
247250
@{VirtualNetworkResourceId=$vnet2;Action="allow"}) `
248-
-ResourceAccessRule (@{ResourceId=$vnet1;TenantId=$globalNode.tenantId},
249-
@{ResourceId=$vnet2;TenantId=$globalNode.tenantId})
251+
-ResourceAccessRule (@{ResourceId=$resourceId1;TenantId=$globalNode.tenantId},
252+
@{ResourceId=$resourceId2;TenantId=$globalNode.tenantId})
250253
$rule.ResourceAccessRules.Count | should -be 2
251254
$rule.Bypass | should -be AzureServices
252255
$rule.DefaultAction | should -be Allow
@@ -289,11 +292,11 @@ Describe "Management plan test" {
289292
echo "Clean the ResourceAccessRules, and add 2 Rules"
290293
$rule = Update-AzStorageAccountNetworkRuleSet -ResourceGroupName $rgname -Name $accountNameNetRule1 -ResourceAccessRule @()
291294
$rule.ResourceAccessRules.Count | should -be 0
292-
$resrule = Add-AzStorageAccountNetworkRule -ResourceGroupName $rgname -Name $accountNameNetRule1 -TenantId $globalNode.tenantId -ResourceId $vnet1
295+
$resrule = Add-AzStorageAccountNetworkRule -ResourceGroupName $rgname -Name $accountNameNetRule1 -TenantId $globalNode.tenantId -ResourceId $resourceId1
293296
$resrule.Count | should -be 1
294-
$resrule = Add-AzStorageAccountNetworkRule -ResourceGroupName $rgname -Name $accountNameNetRule1 -TenantId $globalNode.tenantId -ResourceId $vnet2
297+
$resrule = Add-AzStorageAccountNetworkRule -ResourceGroupName $rgname -Name $accountNameNetRule1 -TenantId $globalNode.tenantId -ResourceId $resourceId2
295298
$resrule.Count | should -be 2
296-
$resrule = Remove-AzStorageAccountNetworkRule -ResourceGroupName $rgname -Name $accountNameNetRule1 -TenantId $globalNode.tenantId -ResourceId $vnet1
299+
$resrule = Remove-AzStorageAccountNetworkRule -ResourceGroupName $rgname -Name $accountNameNetRule1 -TenantId $globalNode.tenantId -ResourceId $resourceId1
297300
$resrule.Count | should -be 1
298301

299302
#Clean the IpRules on Account2, Pipeline to add IpRules from Account1 to Account2

0 commit comments

Comments
 (0)