Skip to content

Fix some mypy errors #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 7, 2025
Merged

Fix some mypy errors #3044

merged 5 commits into from
May 7, 2025

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 7, 2025

I had a long train journey yesterday, so here's some misc mypy fixes.

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 7, 2025
Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just needs release notes

@dstansby
Copy link
Contributor Author

dstansby commented May 7, 2025

Given these are all minor fixes to tests, can I skip the release notes?

@d-v-b
Copy link
Contributor

d-v-b commented May 7, 2025

Given these are all minor fixes to tests, can I skip the release notes?

sure!

@d-v-b d-v-b enabled auto-merge (squash) May 7, 2025 18:24
@d-v-b d-v-b merged commit 693324c into zarr-developers:main May 7, 2025
30 checks passed
@dstansby dstansby deleted the mypy-improve branch May 7, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants