API PullReviewComment HTMLPullURL should return the HTMLURL (go-gitea#11501)

zeripath · techknowlogick · zeripath · commit 0a4f5098f8b0 · 2020-05-21T09:10:24.000+01:00
Fix go-gitea#11499 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
diff --git a/modules/convert/pull_review.go b/modules/convert/pull_review.go
@@ -103,7 +103,7 @@ func ToPullReviewCommentList(review *models.Review, doer *models.User) ([]*api.P
 					OrigCommitID: comment.OldRef,
 					DiffHunk:     patch2diff(comment.Patch),
 					HTMLURL:      comment.HTMLURL(),
-					HTMLPullURL:  review.Issue.APIURL(),
+					HTMLPullURL:  review.Issue.HTMLURL(),
 				}
 
 				if comment.Line < 0 {

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ func ToPullReviewCommentList(review models.Review, doer models.User) ([]*api.P`
`103`	`103`	`OrigCommitID: comment.OldRef,`
`104`	`104`	`DiffHunk: patch2diff(comment.Patch),`
`105`	`105`	`HTMLURL: comment.HTMLURL(),`
`106`		`- HTMLPullURL: review.Issue.APIURL(),`
	`106`	`+ HTMLPullURL: review.Issue.HTMLURL(),`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`if comment.Line < 0 {`