Convert plumbing.ErrReferenceNotFound to git.ErrNotExist in GetRefCommitID (go-gitea#10676) (go-gitea#10797)

* Fix panic in API pulls when headbranch does not exist (go-gitea#10676)

Backport go-gitea#10676

* Fix panic in API pulls when headbranch does not exist
* refix other reference to plumbing.ErrReferenceNotFound

Signed-off-by: Andrew Thornton <[email protected]>

* Apply suggestions from code review

Co-Authored-By: Lauris BH <[email protected]>

Author: zeripath

modules/git/repo_commit.go

@@ -12,15 +12,20 @@ import (
 	"strconv"
 	"strings"
 
+	"github.com/mcuadros/go-version"
 	"github.com/go-git/go-git/v5/plumbing"
 	"github.com/go-git/go-git/v5/plumbing/object"
-	"github.com/mcuadros/go-version"
 )
 
 // GetRefCommitID returns the last commit ID string of given reference (branch or tag).
 func (repo *Repository) GetRefCommitID(name string) (string, error) {
 	ref, err := repo.gogitRepo.Reference(plumbing.ReferenceName(name), true)
 	if err != nil {
+		if err == plumbing.ErrReferenceNotFound {
+			return "", ErrNotExist{
+				ID: name,
+			}
+		}
 		return "", err
 	}
 

routers/repo/branch.go

@@ -16,8 +16,6 @@ import (
 	"code.gitea.io/gitea/modules/log"
 	"code.gitea.io/gitea/modules/repofiles"
 	"code.gitea.io/gitea/modules/util"
-
-	"github.com/go-git/go-git/v5/plumbing"
 )
 
 const (
@@ -253,7 +251,7 @@ func loadBranches(ctx *context.Context) []*Branch {
 					repoIDToGitRepo[pr.BaseRepoID] = baseGitRepo
 				}
 				pullCommit, err := baseGitRepo.GetRefCommitID(pr.GetGitRefName())
-				if err != nil && err != plumbing.ErrReferenceNotFound {
+				if err != nil && !git.IsErrNotExist(err) {
 					ctx.ServerError("GetBranchCommitID", err)
 					return nil
 				}