Skip to content

Commit 8260fbb

Browse files
committed
[libcxx] Marks transform_error.mandates.verify.cpp unsupported on msvc
PR llvm#102851 marks reference types in union as error on msvc by changing the clang, which makes 'transform_error.mandates.verify.cpp' no longer failing on msvc from ToT. However, all libcxx buildbots do not build clang from source, therefore, this test will still fail on these bots, which is incorrect. This patch marks this test as unsupportted on msvc so both bots using ToT clang and release version clang can be green.
1 parent 51ede55 commit 8260fbb

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

libcxx/test/libcxx/utilities/expected/expected.expected/transform_error.mandates.verify.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,12 @@
1010
// minimum required version these obsolete tests can be removed.
1111
// TODO(LLVM-20) remove spurious clang diagnostic tests.
1212

13-
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
14-
1513
// With clang-cl, some warnings have a 'which is a Microsoft extension' suffix
16-
// which break the tests.
17-
// XFAIL: msvc
14+
// which break the tests. But #102851 will turn it into an error, making the test pass.
15+
// However, upstream libcxx buildbots do not build clang from source while testing, so
16+
// this tests still expected to fail on these bots. Mark msvc as unsupported to mitigate
17+
// this issue.
18+
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20, msvc
1819

1920
// Test the mandates
2021

libcxx/test/libcxx/utilities/expected/expected.void/transform_error.mandates.verify.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,12 @@
1010
// minumum required version these obsolete tests can be removed.
1111
// TODO(LLVM-20) remove spurious clang diagnostic tests.
1212

13-
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
14-
1513
// With clang-cl, some warnings have a 'which is a Microsoft extension' suffix
16-
// which break the tests.
17-
// XFAIL: msvc
14+
// which break the tests. But #102851 will turn it into an error, making the test pass.
15+
// However, upstream libcxx buildbots do not build clang from source while testing, so
16+
// this tests still expected to fail on these bots. Mark msvc as unsupported to mitigate
17+
// this issue.
18+
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20, msvc
1819

1920
// Test the mandates
2021

0 commit comments

Comments
 (0)