Bug#34854806 UtilTransactions compilation warnings [#1]

Compilation warning/error:
storage/ndb/test/src/UtilTransactions.cpp:1544: error: variable 'eof'
may be uninitialized when used here [-Werror,-Wconditional-
uninitialized]

Manual code inspection also shows there are problems with
retry logic as well as potentially releasing resources.

Fix by refactoring ´verifyTableReplicasWithSource` into functions where
the retry, scan and compare logic are separated. This makes it possible
to make sure that the "eof" variable is always initialized while
fetching the next row during scan.

Change-Id: I111e0a6613622aa2279a5ec5845e48e8ca0e115f

Author: blaudden

storage/ndb/test/include/UtilTransactions.hpp

@@ -295,6 +295,11 @@ class UtilTransactions {
 			 bool transactional = false,
                          bool findNulls = false);
 
+  int verifyTableReplicasPkCompareRow(Ndb* pNdb, Uint32 nodeId,
+                                      const NDBT_ResultRow& scanRow);
+  int verifyTableReplicasScanAndCompareNodes(Ndb* pNdb, Uint32 sourceNodeId,
+                                             Uint32 numDataNodes,
+                                             Uint32 dataNodes[256]);
   int verifyTableReplicasWithSource(Ndb*, Uint32 sourceNodeId=0);
 
   int verifyOrderedIndexViews(Ndb* pNdb,