Bug#34854806 UtilTransactions compilation warnings [mysql#4]

blaudden · blaudden · commit b3babf3ae529 · 2022-12-14T13:21:28.000+01:00
Potential read of uninitialized dataNodes[0] when no alive nodes are
available. Fix by checking for zero data nodes and fail test.

trunk/storage/ndb/test/src/UtilTransactions.cpp:1710:9: warning: 3rd
function call argument is an uninitialized value [clang-analyzer-
core.CallAndMessage]

Change-Id: I7c1e362eb0d62bdb560967144ca39966aed8a3c1
diff --git a/storage/ndb/test/src/UtilTransactions.cpp b/storage/ndb/test/src/UtilTransactions.cpp
@@ -1718,6 +1718,12 @@ UtilTransactions::verifyOrderedIndexViews(Ndb* pNdb,
     //ndbout_c("Found %u data nodes", numDataNodes);
   }
 
+  if (numDataNodes == 0)
+  {
+    /* No alive nodes */
+    return NDBT_FAILED;
+  }
+
   if (numDataNodes == 1)
   {
     /* No replicas */

Original file line number	Diff line number	Diff line change
`@@ -1718,6 +1718,12 @@ UtilTransactions::verifyOrderedIndexViews(Ndb* pNdb,`
`1718`	`1718`	`//ndbout_c("Found %u data nodes", numDataNodes);`
`1719`	`1719`	`}`
`1720`	`1720`
	`1721`	`+ if (numDataNodes == 0)`
	`1722`	`+ {`
	`1723`	`+ /* No alive nodes */`
	`1724`	`+ return NDBT_FAILED;`
	`1725`	`+ }`
	`1726`	`+`
`1721`	`1727`	`if (numDataNodes == 1)`
`1722`	`1728`	`{`
`1723`	`1729`	`/* No replicas */`