Fix corner case: serializing a valid type with an invalid value

Author: puddly

tests/test_commands.py

@@ -178,6 +178,10 @@ def test_command_param_binding():
     with pytest.raises(ValueError):
         c.UtilCommands.TimeAlive.Rsp(Seconds=b"asd")
 
+    # Valid type but invalid value
+    with pytest.raises(ValueError):
+        c.UtilCommands.SetPreConfigKey.Req(PreConfigKey=t.KeyData([1, 2, 3]))
+
     # Coerced numerical type
     a = c.UtilCommands.TimeAlive.Rsp(Seconds=12)
     b = c.UtilCommands.TimeAlive.Rsp(Seconds=t.uint32_t(12))

zigpy_znp/types/commands.py

@@ -363,13 +363,13 @@ def __init__(self, *, partial=False, **params):
                         f"type {param.type}, got {type(value)}"
                     )
 
-                try:
-                    # XXX: Break early if a type cannot be serialized
-                    value.serialize()
-                except Exception as e:
-                    raise ValueError(
-                        f"Invalid parameter value: {param.name}={value!r}"
-                    ) from e
+            try:
+                # XXX: Break early if a type cannot be serialized
+                value.serialize()
+            except Exception as e:
+                raise ValueError(
+                    f"Invalid parameter value: {param.name}={value!r}"
+                ) from e
 
             bound_params[param.name] = (param, value)