Perform pin toggling before startup and extend timeout

Author: puddly

tests/api/test_connect.py

@@ -102,17 +102,9 @@ async def test_connect_skip_bootloader_rts_dtr_pins(make_znp_server, mocker):
     mocker.patch.object(znp.nvram, "determine_alignment", new=CoroutineMock())
     mocker.patch.object(znp, "detect_zstack_version", new=CoroutineMock())
 
-    num_pings = 0
-
-    def ping_rsp(req):
-        nonlocal num_pings
-        num_pings += 1
-
-        if num_pings >= 3:
-            return c.SYS.Ping.Rsp(Capabilities=t.MTCapabilities.SYS)
-
-    # Ignore the first few pings so we trigger the pin toggling
-    znp_server.reply_to(c.SYS.Ping.Req(), responses=ping_rsp)
+    znp_server.reply_to(
+        c.SYS.Ping.Req(), responses=[c.SYS.Ping.Rsp(Capabilities=t.MTCapabilities.SYS)]
+    )
 
     await znp.connect(test_port=True)
 

zigpy_znp/api.py

@@ -38,7 +38,7 @@
 NETWORK_COMMISSIONING_TIMEOUT = 30
 BOOTLOADER_PIN_TOGGLE_DELAY = 0.15
 CONNECT_PING_TIMEOUT = 0.50
-CONNECT_PROBE_TIMEOUT = 5.0
+CONNECT_PROBE_TIMEOUT = 10
 
 
 class ZNP:
@@ -468,6 +468,16 @@ async def _skip_bootloader(self) -> c.SYS.Ping.Rsp:
         """
 
         async def ping_task():
+            LOGGER.debug("Toggling RTS/DTR pins to skip bootloader or reset chip")
+
+            # The default sequence is DTR=false and RTS toggling false/true/false
+            for dtr, rts in zip(
+                self._znp_config[conf.CONF_CONNECT_DTR_STATES],
+                self._znp_config[conf.CONF_CONNECT_RTS_STATES],
+            ):
+                self._uart.set_dtr_rts(dtr=dtr, rts=rts)
+                await asyncio.sleep(BOOTLOADER_PIN_TOGGLE_DELAY)
+
             # First, just try pinging
             try:
                 async with async_timeout.timeout(CONNECT_PING_TIMEOUT):
@@ -488,20 +498,8 @@ async def ping_task():
             except asyncio.TimeoutError:
                 pass
 
-            # This is normally done just for Slaesh's CC2652RB stick
-            LOGGER.debug("Toggling RTS/DTR pins to skip bootloader or reset chip")
-
-            # The default sequence is DTR=false and RTS toggling false/true/false
-            for dtr, rts in zip(
-                self._znp_config[conf.CONF_CONNECT_DTR_STATES],
-                self._znp_config[conf.CONF_CONNECT_RTS_STATES],
-            ):
-                self._uart.set_dtr_rts(dtr=dtr, rts=rts)
-                await asyncio.sleep(BOOTLOADER_PIN_TOGGLE_DELAY)
-
             # At this point we have nothing else to try, don't catch the timeout
-            async with async_timeout.timeout(CONNECT_PING_TIMEOUT):
-                return await self.request(c.SYS.Ping.Req())
+            return await self.request(c.SYS.Ping.Req())
 
         async with self.capture_responses([CatchAllResponse()]) as responses:
             ping_task = asyncio.create_task(ping_task())

zigpy_znp/zigbee/application.py

@@ -135,15 +135,15 @@ async def probe(cls, device_config: conf.ConfigType) -> bool:
         LOGGER.debug("Probing %s", znp._port_path)
 
         try:
-            async with async_timeout.timeout(PROBE_TIMEOUT):
-                await znp.connect()
-
-            return True
+            # `ZNP.connect` times out on its own
+            await znp.connect()
         except Exception as e:
             LOGGER.debug(
                 "Failed to probe ZNP radio with config %s", device_config, exc_info=e
             )
             return False
+        else:
+            return True
         finally:
             znp.close()