Increase test coverage and improve parsing error messages

Author: puddly

tests/test_commands.py

@@ -276,14 +276,22 @@ def test_command_optional_params():
     assert Version.from_frame(medium_version_rsp.to_frame()) == medium_version_rsp
     assert Version.from_frame(short_version_rsp.to_frame()) == short_version_rsp
 
-    # Deserialization still fails if the frame is incomplete or too long
+    # Deserialization still fails if the frame is incomplete
     with pytest.raises(ValueError):
         Version.from_frame(
             frames.GeneralFrame(
                 header=long_version_rsp.to_frame().header, data=long_data[:-1]
             )
         )
 
+    # Deserialization will fail if the frame is incomplete but has no truncated fields
+    with pytest.raises(ValueError):
+        Version.from_frame(
+            frames.GeneralFrame(
+                header=long_version_rsp.to_frame().header, data=long_data[:4]
+            )
+        )
+
     with pytest.raises(ValueError):
         Version.from_frame(
             frames.GeneralFrame(

tests/test_types_named.py

@@ -124,3 +124,12 @@ def test_zdo_nullable_node_descriptor():
 
     assert not data
     assert desc2.serialize() == desc3.serialize()
+
+
+def test_missing_enum_mixin():
+    class TestEnum(t.MissingEnumMixin, t.enum_uint8):
+        FOO = 0x01
+
+    assert TestEnum(0x01) == 0x01 == TestEnum.FOO
+    assert TestEnum(0x02) == 0x02
+    assert 0x02 not in TestEnum._value2member_map_

zigpy_znp/types/commands.py

@@ -420,7 +420,7 @@ def from_frame(cls, frame, *, ignore_unparsed=False) -> "CommandBase":
             elif not param.optional:
                 # If we're out of data but the parameter is required, this is bad
                 raise ValueError(
-                    f"Frame has been parsed but parameters remain: {param}"
+                    f"Data has been consumed but required parameters remain: {param}"
                 )
             else:
                 # If we're out of data and the parameter is optional, we're done