Implement LED control (fixes #20)

Author: puddly

tests/test_application.py

@@ -88,7 +88,7 @@ async def callback(request):
             if callback.called:
                 return
 
-            callback.called = True
+            callback.called = request
 
             for response in responses:
                 await asyncio.sleep(0.001)
@@ -99,7 +99,7 @@ async def callback(request):
                 else:
                     self.send(response)
 
-            called_future.set_result(True)
+            called_future.set_result(request)
 
         callback.called = False
         self.callback_for_response(request, lambda r: asyncio.create_task(callback(r)))
@@ -402,6 +402,24 @@ async def test_application_startup_tx_power(application):
     await set_tx_power
 
 
+@pytest_mark_asyncio_timeout(seconds=3)
+async def test_application_startup_led_mode(application):
+    app, znp_server = application
+
+    set_led_mode = znp_server.reply_once_to(
+        request=c.Util.LEDControl.Req(partial=True),
+        responses=[c.Util.LEDControl.Rsp(Status=t.Status.SUCCESS)],
+    )
+
+    app.update_config({conf.CONF_ZNP_CONFIG: {conf.CONF_LED_MODE: "off"}})
+
+    await app.startup(auto_form=False)
+    led_req = await set_led_mode
+
+    assert led_req.Mode == c.util.LEDMode.OFF
+    assert led_req.LED == 0xFF
+
+
 @pytest_mark_asyncio_timeout(seconds=3)
 async def test_permit_join(application):
     app, znp_server = application

zigpy_znp/commands/util.py

@@ -25,6 +25,14 @@ class RandomNumbers(t.FixedList, item_type=t.uint8_t, length=0x64):
     pass
 
 
+class LEDMode(t.enum_uint8):
+    OFF = 0
+    ON = 1
+    BLINK = 2
+    FLASH = 3
+    TOGGLE = 4
+
+
 class Util(t.CommandsBase, subsystem=t.Subsystem.UTIL):
     # MAC Reset command to reset MAC state machine
     GetDeviceInfo = t.CommandDef(
@@ -189,8 +197,8 @@ class Util(t.CommandsBase, subsystem=t.Subsystem.UTIL):
         0x0A,
         req_schema=t.Schema(
             (
-                t.Param("Laded", t.uint8_t, "The LED number"),
-                t.Param("On", t.Bool, "True -- On, False -- Off"),
+                t.Param("LED", t.uint8_t, "The LED number. 0xFF for all."),
+                t.Param("Mode", LEDMode, "LED mode. ON/OFF are static."),
             )
         ),
         rsp_schema=t.STATUS_SCHEMA,

zigpy_znp/config.py

@@ -2,6 +2,8 @@
 import numbers
 
 import voluptuous as vol
+
+from zigpy_znp.commands.util import LEDMode
 from zigpy.config import (  # noqa: F401
     CONFIG_SCHEMA,
     SCHEMA_DEVICE,
@@ -36,11 +38,22 @@
 )
 
 
+def EnumValue(enum, transformer=str):
+    def validator(v):
+        if isinstance(v, enum):
+            return v
+
+        return enum[transformer(v)]
+
+    return validator
+
+
 CONF_ZNP_CONFIG = "znp_config"
 CONF_TX_POWER = "tx_power"
+CONF_LED_MODE = "led_mode"
+CONF_SKIP_BOOTLOADER = "skip_bootloader"
 CONF_SREQ_TIMEOUT = "sync_request_timeout"
 CONF_AUTO_RECONNECT_RETRY_DELAY = "auto_reconnect_retry_delay"
-CONF_SKIP_BOOTLOADER = "skip_bootloader"
 
 CONFIG_SCHEMA = CONFIG_SCHEMA.extend(
     {
@@ -55,6 +68,9 @@
                     CONF_AUTO_RECONNECT_RETRY_DELAY, default=5
                 ): VolPositiveNumber,
                 vol.Optional(CONF_SKIP_BOOTLOADER, default=True): cv_boolean,
+                vol.Optional(CONF_LED_MODE, default=None): vol.Any(
+                    None, EnumValue(LEDMode, lambda v: str(v).upper())
+                ),
             }
         ),
     }

zigpy_znp/zigbee/application.py

@@ -354,6 +354,14 @@ async def startup(self, auto_form=False):
                 c.SYS.SetTxPower.Req(TXPower=dbm), RspStatus=t.Status.SUCCESS
             )
 
+        if self.config[conf.CONF_ZNP_CONFIG][conf.CONF_LED_MODE] is not None:
+            led_mode = self.config[conf.CONF_ZNP_CONFIG][conf.CONF_LED_MODE]
+
+            await self._znp.request(
+                c.Util.LEDControl.Req(LED=0xFF, Mode=led_mode),
+                RspStatus=t.Status.SUCCESS,
+            )
+
         device_info = await self._znp.request(
             c.Util.GetDeviceInfo.Req(), RspStatus=t.Status.SUCCESS
         )