Skip to content

Commit 586066b

Browse files
committed
Fix ":" not being removed from the directory name
Add specs for the directory name Closes #137
1 parent 66e13b0 commit 586066b

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

lib/rspec_api_documentation/views/markup_example.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def respond_to?(method, include_private = false)
1919
end
2020

2121
def dirname
22-
resource_name.downcase.gsub(/\s+/, '_')
22+
resource_name.downcase.gsub(/\s+/, '_').gsub(":", "_")
2323
end
2424

2525
def filename

spec/views/html_example_spec.rb

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,31 @@
22
require 'spec_helper'
33

44
describe RspecApiDocumentation::Views::HtmlExample do
5-
let(:metadata) { {} }
5+
let(:metadata) { { :resource_name => "Orders" } }
66
let(:group) { RSpec::Core::ExampleGroup.describe("Orders", metadata) }
7-
let(:example) { group.example("Ordering a cup of coffee") {} }
7+
let(:rspec_example) { group.example("Ordering a cup of coffee") {} }
8+
let(:rad_example) do
9+
RspecApiDocumentation::Example.new(rspec_example, configuration)
10+
end
811
let(:configuration) { RspecApiDocumentation::Configuration.new }
9-
let(:html_example) { described_class.new(example, configuration) }
12+
let(:html_example) { described_class.new(rad_example, configuration) }
13+
14+
specify "the directory is 'orders'" do
15+
expect(html_example.dirname).to eq("orders")
16+
end
1017

1118
it "should have downcased filename" do
1219
expect(html_example.filename).to eq("ordering_a_cup_of_coffee.html")
1320
end
1421

1522
describe "multi charctor example name" do
23+
let(:metadata) { { :resource_name => "オーダ" } }
1624
let(:label) { "Coffee / Teaが順番で並んでいること" }
17-
let(:example) { group.example(label) {} }
25+
let(:rspec_example) { group.example(label) {} }
26+
27+
specify "the directory is 'オーダ'" do
28+
expect(html_example.dirname).to eq("オーダ")
29+
end
1830

1931
it "should have downcased filename" do
2032
expect(html_example.filename).to eq("coffee__teaが順番で並んでいること.html")

0 commit comments

Comments
 (0)