Skip to content

Commit 08e02eb

Browse files
committed
compose test [nfc]: Add a parent test group
This will make it ready for the next commit(s) where we add another sub-group test.
1 parent 4926c92 commit 08e02eb

File tree

1 file changed

+64
-62
lines changed

1 file changed

+64
-62
lines changed

test/widgets/compose_box_test.dart

Lines changed: 64 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -578,7 +578,7 @@ void main() {
578578
});
579579
});
580580

581-
group('compose box in DMs with deactivated users', () {
581+
group('error banner', () {
582582
Finder contentFieldFinder() => find.descendant(
583583
of: find.byType(ComposeBox),
584584
matching: find.byType(TextField));
@@ -605,81 +605,83 @@ void main() {
605605
checkBanner(isShown: !isShown);
606606
}
607607

608-
Future<void> changeUserStatus(WidgetTester tester,
609-
{required User user, required bool isActive}) async {
610-
await store.handleEvent(RealmUserUpdateEvent(id: 1,
611-
userId: user.userId, isActive: isActive));
612-
await tester.pump();
613-
}
608+
group('in DMs with deactivated users', () {
609+
Future<void> changeUserStatus(WidgetTester tester,
610+
{required User user, required bool isActive}) async {
611+
await store.handleEvent(RealmUserUpdateEvent(id: 1,
612+
userId: user.userId, isActive: isActive));
613+
await tester.pump();
614+
}
614615

615-
DmNarrow dmNarrowWith(User otherUser) => DmNarrow.withUser(otherUser.userId,
616-
selfUserId: eg.selfUser.userId);
616+
DmNarrow dmNarrowWith(User otherUser) => DmNarrow.withUser(otherUser.userId,
617+
selfUserId: eg.selfUser.userId);
617618

618-
DmNarrow groupDmNarrowWith(List<User> otherUsers) => DmNarrow.withOtherUsers(
619-
otherUsers.map((u) => u.userId), selfUserId: eg.selfUser.userId);
619+
DmNarrow groupDmNarrowWith(List<User> otherUsers) => DmNarrow.withOtherUsers(
620+
otherUsers.map((u) => u.userId), selfUserId: eg.selfUser.userId);
620621

621-
group('1:1 DMs', () {
622-
testWidgets('compose box replaced with a banner', (tester) async {
623-
final deactivatedUser = eg.user(isActive: false);
624-
await prepareComposeBox(tester, narrow: dmNarrowWith(deactivatedUser),
625-
users: [deactivatedUser]);
626-
checkComposeBox(isShown: false);
627-
});
622+
group('1:1 DMs', () {
623+
testWidgets('compose box replaced with a banner', (tester) async {
624+
final deactivatedUser = eg.user(isActive: false);
625+
await prepareComposeBox(tester, narrow: dmNarrowWith(deactivatedUser),
626+
users: [deactivatedUser]);
627+
checkComposeBox(isShown: false);
628+
});
628629

629-
testWidgets('active user becomes deactivated -> '
630-
'compose box is replaced with a banner', (tester) async {
631-
final activeUser = eg.user(isActive: true);
632-
await prepareComposeBox(tester, narrow: dmNarrowWith(activeUser),
633-
users: [activeUser]);
634-
checkComposeBox(isShown: true);
630+
testWidgets('active user becomes deactivated -> '
631+
'compose box is replaced with a banner', (tester) async {
632+
final activeUser = eg.user(isActive: true);
633+
await prepareComposeBox(tester, narrow: dmNarrowWith(activeUser),
634+
users: [activeUser]);
635+
checkComposeBox(isShown: true);
635636

636-
await changeUserStatus(tester, user: activeUser, isActive: false);
637-
checkComposeBox(isShown: false);
638-
});
637+
await changeUserStatus(tester, user: activeUser, isActive: false);
638+
checkComposeBox(isShown: false);
639+
});
639640

640-
testWidgets('deactivated user becomes active -> '
641-
'banner is replaced with the compose box', (tester) async {
642-
final deactivatedUser = eg.user(isActive: false);
643-
await prepareComposeBox(tester, narrow: dmNarrowWith(deactivatedUser),
644-
users: [deactivatedUser]);
645-
checkComposeBox(isShown: false);
641+
testWidgets('deactivated user becomes active -> '
642+
'banner is replaced with the compose box', (tester) async {
643+
final deactivatedUser = eg.user(isActive: false);
644+
await prepareComposeBox(tester, narrow: dmNarrowWith(deactivatedUser),
645+
users: [deactivatedUser]);
646+
checkComposeBox(isShown: false);
646647

647-
await changeUserStatus(tester, user: deactivatedUser, isActive: true);
648-
checkComposeBox(isShown: true);
648+
await changeUserStatus(tester, user: deactivatedUser, isActive: true);
649+
checkComposeBox(isShown: true);
650+
});
649651
});
650-
});
651652

652-
group('group DMs', () {
653-
testWidgets('compose box replaced with a banner', (tester) async {
654-
final deactivatedUsers = [eg.user(isActive: false), eg.user(isActive: false)];
655-
await prepareComposeBox(tester, narrow: groupDmNarrowWith(deactivatedUsers),
656-
users: deactivatedUsers);
657-
checkComposeBox(isShown: false);
658-
});
653+
group('group DMs', () {
654+
testWidgets('compose box replaced with a banner', (tester) async {
655+
final deactivatedUsers = [eg.user(isActive: false), eg.user(isActive: false)];
656+
await prepareComposeBox(tester, narrow: groupDmNarrowWith(deactivatedUsers),
657+
users: deactivatedUsers);
658+
checkComposeBox(isShown: false);
659+
});
659660

660-
testWidgets('at least one user becomes deactivated -> '
661-
'compose box is replaced with a banner', (tester) async {
662-
final activeUsers = [eg.user(isActive: true), eg.user(isActive: true)];
663-
await prepareComposeBox(tester, narrow: groupDmNarrowWith(activeUsers),
664-
users: activeUsers);
665-
checkComposeBox(isShown: true);
661+
testWidgets('at least one user becomes deactivated -> '
662+
'compose box is replaced with a banner', (tester) async {
663+
final activeUsers = [eg.user(isActive: true), eg.user(isActive: true)];
664+
await prepareComposeBox(tester, narrow: groupDmNarrowWith(activeUsers),
665+
users: activeUsers);
666+
checkComposeBox(isShown: true);
666667

667-
await changeUserStatus(tester, user: activeUsers[0], isActive: false);
668-
checkComposeBox(isShown: false);
669-
});
668+
await changeUserStatus(tester, user: activeUsers[0], isActive: false);
669+
checkComposeBox(isShown: false);
670+
});
670671

671-
testWidgets('all deactivated users become active -> '
672-
'banner is replaced with the compose box', (tester) async {
673-
final deactivatedUsers = [eg.user(isActive: false), eg.user(isActive: false)];
674-
await prepareComposeBox(tester, narrow: groupDmNarrowWith(deactivatedUsers),
675-
users: deactivatedUsers);
676-
checkComposeBox(isShown: false);
672+
testWidgets('all deactivated users become active -> '
673+
'banner is replaced with the compose box', (tester) async {
674+
final deactivatedUsers = [eg.user(isActive: false), eg.user(isActive: false)];
675+
await prepareComposeBox(tester, narrow: groupDmNarrowWith(deactivatedUsers),
676+
users: deactivatedUsers);
677+
checkComposeBox(isShown: false);
677678

678-
await changeUserStatus(tester, user: deactivatedUsers[0], isActive: true);
679-
checkComposeBox(isShown: false);
679+
await changeUserStatus(tester, user: deactivatedUsers[0], isActive: true);
680+
checkComposeBox(isShown: false);
680681

681-
await changeUserStatus(tester, user: deactivatedUsers[1], isActive: true);
682-
checkComposeBox(isShown: true);
682+
await changeUserStatus(tester, user: deactivatedUsers[1], isActive: true);
683+
checkComposeBox(isShown: true);
684+
});
683685
});
684686
});
685687
});

0 commit comments

Comments
 (0)