Skip to content

Commit 1531b9e

Browse files
committed
content [nfc]: Comment about not setting Heading weight relative to context
1 parent 6d246ae commit 1531b9e

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

lib/widgets/content.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,11 @@ class Heading extends StatelessWidget {
252252
fontSize: kBaseFontSize * emHeight,
253253
height: 1.4,
254254
)
255+
// Could set boldness relative to ambient text style, which itself
256+
// might be bolder than normal (e.g. in spoiler headers).
257+
// But this didn't seem like a clear improvement and would make inline
258+
// **bold** spans less distinct; discussion:
259+
// https://github.com/zulip/zulip-flutter/pull/706#issuecomment-2141326257
255260
.merge(weightVariableTextStyle(context, wght: 600)),
256261
node: node));
257262
}

0 commit comments

Comments
 (0)