store [nfc]: Add assertion on zulipFeatureLevel

Author: PIG208

lib/model/store.dart

@@ -571,6 +571,7 @@ class PerAccountStore extends PerAccountStoreBase with ChangeNotifier, EmojiStor
   /// be empty otherwise.
   // TODO(server-10) simplify this
   String get realmEmptyTopicDisplayName {
+    assert(zulipFeatureLevel >= 334);
     assert(_realmEmptyTopicDisplayName != null); // TODO(log)
     return _realmEmptyTopicDisplayName ?? 'general chat';
   }

test/widgets/action_sheet_test.dart

@@ -450,7 +450,7 @@ void main() {
       });
 
       testWidgets('show from app bar: resolve/unresolve not offered when topic is empty', (tester) async {
-        await prepare();
+        await prepare(zulipFeatureLevel: 334);
         final message = eg.streamMessage(stream: someChannel, topic: '');
         await showFromAppBar(tester,
           topic: TopicName(''),

test/widgets/autocomplete_test.dart

@@ -100,11 +100,14 @@ Future<Finder> setupToComposeInput(WidgetTester tester, {
 Future<Finder> setupToTopicInput(WidgetTester tester, {
   required List<GetStreamTopicsEntry> topics,
   String? realmEmptyTopicDisplayName,
+  int? zulipFeatureLevel,
 }) async {
   addTearDown(testBinding.reset);
-  await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot(
+  final account = eg.selfAccount.copyWith(zulipFeatureLevel: zulipFeatureLevel);
+  await testBinding.globalStore.add(account, eg.initialSnapshot(
+    zulipFeatureLevel: zulipFeatureLevel,
     realmEmptyTopicDisplayName: realmEmptyTopicDisplayName));
-  final store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
+  final store = await testBinding.globalStore.perAccount(account.id);
   await store.addUser(eg.selfUser);
   final connection = store.connection as FakeApiConnection;
 
@@ -121,7 +124,7 @@ Future<Finder> setupToTopicInput(WidgetTester tester, {
     messages: [message],
   ).toJson());
 
-  await tester.pumpWidget(TestZulipApp(accountId: eg.selfAccount.id,
+  await tester.pumpWidget(TestZulipApp(accountId: account.id,
     child: MessageListPage(initNarrow: ChannelNarrow(stream.streamId))));
   await tester.pumpAndSettle();
 
@@ -465,7 +468,8 @@ void main() {
     testWidgets('display realmEmptyTopicDisplayName for empty topic', (tester) async {
       final topic = eg.getStreamTopicsEntry(name: '');
       final topicInputFinder = await setupToTopicInput(tester, topics: [topic],
-        realmEmptyTopicDisplayName: 'some display name');
+        realmEmptyTopicDisplayName: 'some display name',
+        zulipFeatureLevel: 334);
 
       // TODO(#226): Remove this extra edit when this bug is fixed.
       await tester.enterText(topicInputFinder, ' ');
@@ -478,7 +482,8 @@ void main() {
     testWidgets('match realmEmptyTopicDisplayName in autocomplete', (tester) async {
       final topic = eg.getStreamTopicsEntry(name: '');
       final topicInputFinder = await setupToTopicInput(tester, topics: [topic],
-        realmEmptyTopicDisplayName: 'general chat');
+        realmEmptyTopicDisplayName: 'general chat',
+        zulipFeatureLevel: 334);
 
       // TODO(#226): Remove this extra edit when this bug is fixed.
       await tester.enterText(topicInputFinder, 'general ch');
@@ -491,7 +496,8 @@ void main() {
     testWidgets('autocomplete to realmEmptyTopicDisplayName sets topic to empty string', (tester) async {
       final topic = eg.getStreamTopicsEntry(name: '');
       final topicInputFinder = await setupToTopicInput(tester, topics: [topic],
-        realmEmptyTopicDisplayName: 'general chat');
+        realmEmptyTopicDisplayName: 'general chat',
+        zulipFeatureLevel: 334);
       final controller = tester.widget<TextField>(topicInputFinder).controller!;
 
       // TODO(#226): Remove this extra edit when this bug is fixed.

test/widgets/inbox_test.dart

@@ -58,11 +58,14 @@ void main() {
     List<Subscription>? subscriptions,
     List<User>? users,
     required List<Message> unreadMessages,
+    int? zulipFeatureLevel,
     NavigatorObserver? navigatorObserver,
   }) async {
     addTearDown(testBinding.reset);
-    await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot());
-    store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
+    final account = eg.selfAccount.copyWith(zulipFeatureLevel: zulipFeatureLevel);
+    await testBinding.globalStore.add(account, eg.initialSnapshot(
+      zulipFeatureLevel: zulipFeatureLevel));
+    store = await testBinding.globalStore.perAccount(account.id);
 
     await store.addStreams(streams ?? []);
     await store.addSubscriptions(subscriptions ?? []);
@@ -74,7 +77,7 @@ void main() {
     }
 
     await tester.pumpWidget(TestZulipApp(
-      accountId: eg.selfAccount.id,
+      accountId: account.id,
       navigatorObservers: [if (navigatorObserver != null) navigatorObserver],
       child: const HomePage(),
     ));
@@ -312,7 +315,8 @@ void main() {
       await setupPage(tester,
         streams: [channel],
         subscriptions: [(eg.subscription(channel))],
-        unreadMessages: [eg.streamMessage(stream: channel, topic: '')]);
+        unreadMessages: [eg.streamMessage(stream: channel, topic: '')],
+        zulipFeatureLevel: 334);
       check(find.text(eg.defaultRealmEmptyTopicDisplayName)).findsOne();
     }, skip: true); // null topic names soon to be enabled
 

test/widgets/message_list_test.dart

@@ -201,7 +201,8 @@ void main() {
       await setupMessageListPage(tester,
         narrow: eg.topicNarrow(channel.streamId, ''),
         streams: [channel],
-        messageCount: 1);
+        messageCount: 1,
+        zulipFeatureLevel: 334);
       checkAppBarChannelTopic(
         channel.name, eg.defaultRealmEmptyTopicDisplayName);
     }, skip: true); // null topic names soon to be enabled
@@ -951,7 +952,8 @@ void main() {
       testWidgets('show general chat for empty topics with channel name', (tester) async {
         await setupMessageListPage(tester,
           narrow: const CombinedFeedNarrow(),
-          messages: [messageEmptyTopic], subscriptions: [eg.subscription(stream)]);
+          messages: [messageEmptyTopic], subscriptions: [eg.subscription(stream)],
+          zulipFeatureLevel: 334);
         await tester.pump();
         check(findInMessageList('stream name')).single;
         check(findInMessageList(eg.defaultRealmEmptyTopicDisplayName)).single;
@@ -960,7 +962,8 @@ void main() {
       testWidgets('show general chat for empty topics without channel name', (tester) async {
         await setupMessageListPage(tester,
           narrow: TopicNarrow.ofMessage(messageEmptyTopic),
-          messages: [messageEmptyTopic]);
+          messages: [messageEmptyTopic],
+          zulipFeatureLevel: 334);
         await tester.pump();
         check(findInMessageList('stream name')).isEmpty();
         check(findInMessageList(eg.defaultRealmEmptyTopicDisplayName)).single;