Skip to content

Commit 2f0f469

Browse files
samwighttgnprice
authored andcommitted
sticky_header: Pass new second type argument to SlottedContainerRenderObjectMixin et al.
This is required since flutter/flutter#126108 . The breakage is a reminder that it'd be good to get our repo added to Flutter's "customer tests" suite. Because this isn't a common API to extend, neither that suite nor Google's internal use of Flutter had anything affected by this change, which mean that Flutter's "breaking change" policy treated it as a non-breaking change, the same as an internal refactoring. In addition to these required changes, there's a deprecation of SlottedMultiChildRenderObjectWidgetMixin in favor of an abstract base class. We can take care of that in a separate commit. [greg: wrote new commit message]
1 parent 99c8d10 commit 2f0f469

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

lib/widgets/sticky_header.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ class RenderSliverStickyHeaderList extends RenderSliverList {
211211
enum StickyHeaderSlot { header, content }
212212

213213
class StickyHeader extends RenderObjectWidget
214-
with SlottedMultiChildRenderObjectWidgetMixin<StickyHeaderSlot> {
214+
with SlottedMultiChildRenderObjectWidgetMixin<StickyHeaderSlot, RenderBox> {
215215
StickyHeader(
216216
{super.key,
217217
this.direction = AxisDirection.down,
@@ -236,14 +236,14 @@ class StickyHeader extends RenderObjectWidget
236236
}
237237

238238
@override
239-
SlottedContainerRenderObjectMixin<StickyHeaderSlot> createRenderObject(
239+
SlottedContainerRenderObjectMixin<StickyHeaderSlot, RenderBox> createRenderObject(
240240
BuildContext context) {
241241
return RenderStickyHeader(direction: direction);
242242
}
243243
}
244244

245245
class RenderStickyHeader extends RenderBox
246-
with SlottedContainerRenderObjectMixin<StickyHeaderSlot> {
246+
with SlottedContainerRenderObjectMixin<StickyHeaderSlot, RenderBox> {
247247
RenderStickyHeader({required AxisDirection direction})
248248
: _direction = direction;
249249

0 commit comments

Comments
 (0)