Skip to content

Commit 37e7213

Browse files
committed
deps: Update pigeon to latest
Changelog: https://pub.dev/packages/pigeon/changelog The only breaking change is: Limits the number of total custom types to 126. If more than 126 custom types are needed, consider breaking up your definition files. Which definitely isn't a problem for us! The changes all look pretty innocuous; but just to confirm, I fired up the app (as a release build) and tested end-to-end that notifications still appear. As usual I tested it while the app was in the foreground, in the background, and not running.
1 parent 6818356 commit 37e7213

File tree

4 files changed

+17
-16
lines changed

4 files changed

+17
-16
lines changed

android/app/src/main/kotlin/com/zulip/flutter/Notifications.g.kt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Autogenerated from Pigeon (v19.0.2), do not edit directly.
1+
// Autogenerated from Pigeon (v20.0.1), do not edit directly.
22
// See also: https://pub.dev/packages/pigeon
33
@file:Suppress("UNCHECKED_CAST", "ArrayInDataClass")
44

@@ -75,17 +75,17 @@ data class PendingIntent (
7575
}
7676
}
7777
fun toList(): List<Any?> {
78-
return listOf<Any?>(
78+
return listOf(
7979
requestCode,
8080
intentPayload,
8181
flags,
8282
)
8383
}
8484
}
85-
private object AndroidNotificationHostApiCodec : StandardMessageCodec() {
85+
private object NotificationsPigeonCodec : StandardMessageCodec() {
8686
override fun readValueOfType(type: Byte, buffer: ByteBuffer): Any? {
8787
return when (type) {
88-
128.toByte() -> {
88+
129.toByte() -> {
8989
return (readValue(buffer) as? List<Any?>)?.let {
9090
PendingIntent.fromList(it)
9191
}
@@ -96,7 +96,7 @@ private object AndroidNotificationHostApiCodec : StandardMessageCodec() {
9696
override fun writeValue(stream: ByteArrayOutputStream, value: Any?) {
9797
when (value) {
9898
is PendingIntent -> {
99-
stream.write(128)
99+
stream.write(129)
100100
writeValue(stream, value.toList())
101101
}
102102
else -> super.writeValue(stream, value)
@@ -130,7 +130,7 @@ interface AndroidNotificationHostApi {
130130
companion object {
131131
/** The codec used by AndroidNotificationHostApi. */
132132
val codec: MessageCodec<Any?> by lazy {
133-
AndroidNotificationHostApiCodec
133+
NotificationsPigeonCodec
134134
}
135135
/** Sets up an instance of `AndroidNotificationHostApi` to handle messages through the `binaryMessenger`. */
136136
@JvmOverloads
@@ -152,7 +152,7 @@ interface AndroidNotificationHostApi {
152152
val smallIconResourceNameArg = args[8] as String?
153153
val wrapped: List<Any?> = try {
154154
api.notify(tagArg, idArg, channelIdArg, colorArg, contentIntentArg, contentTextArg, contentTitleArg, extrasArg, smallIconResourceNameArg)
155-
listOf<Any?>(null)
155+
listOf(null)
156156
} catch (exception: Throwable) {
157157
wrapError(exception)
158158
}

lib/host/android_notifications.g.dart

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Autogenerated from Pigeon (v19.0.2), do not edit directly.
1+
// Autogenerated from Pigeon (v20.0.1), do not edit directly.
22
// See also: https://pub.dev/packages/pigeon
33
// ignore_for_file: public_member_api_docs, non_constant_identifier_names, avoid_as, unused_import, unnecessary_parenthesis, prefer_null_aware_operators, omit_local_variable_types, unused_shown_name, unnecessary_import, no_leading_underscores_for_local_identifiers
44

@@ -53,12 +53,13 @@ class PendingIntent {
5353
}
5454
}
5555

56-
class _AndroidNotificationHostApiCodec extends StandardMessageCodec {
57-
const _AndroidNotificationHostApiCodec();
56+
57+
class _PigeonCodec extends StandardMessageCodec {
58+
const _PigeonCodec();
5859
@override
5960
void writeValue(WriteBuffer buffer, Object? value) {
6061
if (value is PendingIntent) {
61-
buffer.putUint8(128);
62+
buffer.putUint8(129);
6263
writeValue(buffer, value.encode());
6364
} else {
6465
super.writeValue(buffer, value);
@@ -68,7 +69,7 @@ class _AndroidNotificationHostApiCodec extends StandardMessageCodec {
6869
@override
6970
Object? readValueOfType(int type, ReadBuffer buffer) {
7071
switch (type) {
71-
case 128:
72+
case 129:
7273
return PendingIntent.decode(readValue(buffer)!);
7374
default:
7475
return super.readValueOfType(type, buffer);
@@ -85,7 +86,7 @@ class AndroidNotificationHostApi {
8586
__pigeon_messageChannelSuffix = messageChannelSuffix.isNotEmpty ? '.$messageChannelSuffix' : '';
8687
final BinaryMessenger? __pigeon_binaryMessenger;
8788

88-
static const MessageCodec<Object?> pigeonChannelCodec = _AndroidNotificationHostApiCodec();
89+
static const MessageCodec<Object?> pigeonChannelCodec = _PigeonCodec();
8990

9091
final String __pigeon_messageChannelSuffix;
9192

pubspec.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -845,10 +845,10 @@ packages:
845845
dependency: "direct dev"
846846
description:
847847
name: pigeon
848-
sha256: "5710a43ab5e7564533758ef2b0b02cd51b15080183603a4f8f11515fe0bbc8a4"
848+
sha256: "012cdc56c09fc901fd44e44cd4ada9a859a839f55e0b0365f1ed683fe0072404"
849849
url: "https://pub.dev"
850850
source: hosted
851-
version: "19.0.2"
851+
version: "20.0.1"
852852
platform:
853853
dependency: transitive
854854
description:

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ dev_dependencies:
8282
fake_async: ^1.3.1
8383
flutter_lints: ^4.0.0
8484
json_serializable: ^6.5.4
85-
pigeon: ^19.0.0
85+
pigeon: ^20.0.1
8686
plugin_platform_interface: ^2.1.8
8787
stack_trace: ^1.11.1
8888
test: ^1.23.1

0 commit comments

Comments
 (0)