Skip to content

Commit 44956c6

Browse files
rajveermalviyagnprice
authored andcommitted
deps: Update flutter_lints to 6.0.0, from 5.0.0
Changelog: https://pub.dev/packages/flutter_lints/changelog#600 Also includes changes to fix lint failures for the new 'unnecessary_underscores' lint, probably to encourage using wildcard variable `_`: https://dart.dev/language/variables#wildcard-variables Without this change `flutter analyze` reports the following: info • Unnecessary use of multiple underscores • lib/widgets/autocomplete.dart:133:40 • unnecessary_underscores info • Unnecessary use of multiple underscores • lib/widgets/autocomplete.dart:156:38 • unnecessary_underscores info • Unnecessary use of multiple underscores • lib/widgets/autocomplete.dart:156:42 • unnecessary_underscores info • Unnecessary use of multiple underscores • lib/widgets/emoji_reaction.dart:333:34 • unnecessary_underscores
1 parent 8f2b647 commit 44956c6

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

lib/widgets/autocomplete.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ class _AutocompleteFieldState<QueryT extends AutocompleteQuery, ResultT extends
130130
// `optionsBuilder` we pass is just a function that returns
131131
// _resultsToDisplay, which is computed with lots of help from
132132
// AutocompleteView.
133-
optionsViewBuilder: (context, _, __) {
133+
optionsViewBuilder: (context, _, _) {
134134
return Align(
135135
alignment: Alignment.bottomLeft,
136136
child: Material(
@@ -153,7 +153,7 @@ class _AutocompleteFieldState<QueryT extends AutocompleteQuery, ResultT extends
153153
// The third isn't helpful; it lets us opt into behavior we don't actually
154154
// want (see discussion:
155155
// <https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/autocomplete.20UI/near/1599994>)
156-
fieldViewBuilder: (context, _, __, ___) => widget.fieldViewBuilder(context),
156+
fieldViewBuilder: (context, _, _, _) => widget.fieldViewBuilder(context),
157157
);
158158
}
159159
}

lib/widgets/emoji_reaction.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ class _ImageEmoji extends StatelessWidget {
330330
// Unicode and text emoji get scaled; it would look weird if image emoji didn't.
331331
textScaler: _squareEmojiScalerClamped(context),
332332
emojiDisplay: emojiDisplay,
333-
errorBuilder: (context, _, __) => _TextEmoji(
333+
errorBuilder: (context, _, _) => _TextEmoji(
334334
emojiDisplay: TextEmojiDisplay(emojiName: emojiName), selected: selected),
335335
);
336336
}

pubspec.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -441,10 +441,10 @@ packages:
441441
dependency: "direct dev"
442442
description:
443443
name: flutter_lints
444-
sha256: "5398f14efa795ffb7a33e9b6a08798b26a180edac4ad7db3f231e40f82ce11e1"
444+
sha256: "3105dc8492f6183fb076ccf1f351ac3d60564bff92e20bfc4af9cc1651f4e7e1"
445445
url: "https://pub.dev"
446446
source: hosted
447-
version: "5.0.0"
447+
version: "6.0.0"
448448
flutter_localizations:
449449
dependency: "direct main"
450450
description: flutter
@@ -682,10 +682,10 @@ packages:
682682
dependency: transitive
683683
description:
684684
name: lints
685-
sha256: c35bb79562d980e9a453fc715854e1ed39e24e7d0297a880ef54e17f9874a9d7
685+
sha256: a5e2b223cb7c9c8efdc663ef484fdd95bb243bff242ef5b13e26883547fce9a0
686686
url: "https://pub.dev"
687687
source: hosted
688-
version: "5.1.1"
688+
version: "6.0.0"
689689
logging:
690690
dependency: transitive
691691
description:

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ dev_dependencies:
9898
drift_dev: ^2.5.2
9999
fake_async: ^1.3.1
100100
flutter_checks: ^0.1.2
101-
flutter_lints: ^5.0.0
101+
flutter_lints: ^6.0.0
102102
ini: ^2.1.0
103103
json_serializable: ^6.5.4
104104
legacy_checks: ^0.1.0

0 commit comments

Comments
 (0)