msglist [nfc]: Rename backoff state to share between older/newer

If a fetch in one direction has recently failed, we'll want the
backoff to apply to any attempt to fetch in the other direction too;
after all, it's the same server.

We can also drop the term "cooldown" here, which is effectively
redundant with "backoff".

Author: gnprice

lib/model/message_list.dart

@@ -78,8 +78,8 @@ enum FetchingStatus {
   /// The model has an active `fetchOlder` request.
   fetchOlder,
 
-  /// The model is in a backoff period from a failed `fetchOlder` request.
-  fetchOlderCoolingDown,
+  /// The model is in a backoff period from a failed request.
+  backoff,
 }
 
 /// The sequence of messages in a message list, and how to display them.
@@ -134,13 +134,13 @@ mixin _MessageSequence {
   /// This is true both when the recent request is still outstanding,
   /// and when it failed and the backoff from that is still in progress.
   bool get busyFetchingMore => switch (_status) {
-    FetchingStatus.fetchOlder || FetchingStatus.fetchOlderCoolingDown => true,
+    FetchingStatus.fetchOlder || FetchingStatus.backoff => true,
     _ => false,
   };
 
   FetchingStatus _status = FetchingStatus.unstarted;
 
-  BackoffMachine? _fetchOlderCooldownBackoffMachine;
+  BackoffMachine? _fetchBackoffMachine;
 
   /// The parsed message contents, as a list parallel to [messages].
   ///
@@ -315,7 +315,7 @@ mixin _MessageSequence {
     middleMessage = 0;
     _haveOldest = false;
     _status = FetchingStatus.unstarted;
-    _fetchOlderCooldownBackoffMachine = null;
+    _fetchBackoffMachine = null;
     contents.clear();
     items.clear();
     middleItem = 0;
@@ -619,17 +619,17 @@ class MessageListView with ChangeNotifier, _MessageSequence {
       if (this.generation == generation) {
         assert(_status == FetchingStatus.fetchOlder);
         if (hasFetchError) {
-          _status = FetchingStatus.fetchOlderCoolingDown;
-          unawaited((_fetchOlderCooldownBackoffMachine ??= BackoffMachine())
+          _status = FetchingStatus.backoff;
+          unawaited((_fetchBackoffMachine ??= BackoffMachine())
             .wait().then((_) {
               if (this.generation != generation) return;
-              assert(_status == FetchingStatus.fetchOlderCoolingDown);
+              assert(_status == FetchingStatus.backoff);
               _status = FetchingStatus.idle;
               notifyListeners();
             }));
         } else {
           _status = FetchingStatus.idle;
-          _fetchOlderCooldownBackoffMachine = null;
+          _fetchBackoffMachine = null;
         }
         notifyListeners();
       }