Skip to content

Commit 6dec95d

Browse files
gnpricechrisbobbe
authored andcommitted
autocomplete [nfc]: Cut "candidate" type param from AutocompleteView
This is no longer used since cfce389 introduced computeResults and eliminated getSortedItemsToTest and testItem from the base class.
1 parent b18d17a commit 6dec95d

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

lib/model/autocomplete.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ class AutocompleteViewManager {
187187
/// * On reassemble, call [reassemble].
188188
/// * When the object will no longer be used, call [dispose] to free
189189
/// resources on the [PerAccountStore].
190-
abstract class AutocompleteView<QueryT extends AutocompleteQuery, ResultT extends AutocompleteResult, CandidateT> extends ChangeNotifier {
190+
abstract class AutocompleteView<QueryT extends AutocompleteQuery, ResultT extends AutocompleteResult> extends ChangeNotifier {
191191
AutocompleteView({required this.store});
192192

193193
final PerAccountStore store;
@@ -284,7 +284,7 @@ abstract class AutocompleteView<QueryT extends AutocompleteQuery, ResultT extend
284284
}
285285
}
286286

287-
class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery, MentionAutocompleteResult, User> {
287+
class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery, MentionAutocompleteResult> {
288288
MentionAutocompleteView._({
289289
required super.store,
290290
required this.narrow,
@@ -589,7 +589,7 @@ class UserMentionAutocompleteResult extends MentionAutocompleteResult {
589589

590590
// TODO(#234): // class WildcardMentionAutocompleteResult extends MentionAutocompleteResult {
591591

592-
class TopicAutocompleteView extends AutocompleteView<TopicAutocompleteQuery, TopicAutocompleteResult, String> {
592+
class TopicAutocompleteView extends AutocompleteView<TopicAutocompleteQuery, TopicAutocompleteResult> {
593593
TopicAutocompleteView._({required super.store, required this.streamId});
594594

595595
factory TopicAutocompleteView.init({required PerAccountStore store, required int streamId}) {

lib/widgets/autocomplete.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@ abstract class AutocompleteField<QueryT extends AutocompleteQuery, ResultT exten
2424

2525
Widget buildItem(BuildContext context, int index, ResultT option);
2626

27-
AutocompleteView<QueryT, ResultT, CandidateT> initViewModel(BuildContext context);
27+
AutocompleteView<QueryT, ResultT> initViewModel(BuildContext context);
2828

2929
@override
3030
State<AutocompleteField<QueryT, ResultT, CandidateT>> createState() => _AutocompleteFieldState<QueryT, ResultT, CandidateT>();
3131
}
3232

3333
class _AutocompleteFieldState<QueryT extends AutocompleteQuery, ResultT extends AutocompleteResult, CandidateT> extends State<AutocompleteField<QueryT, ResultT, CandidateT>> with PerAccountStoreAwareStateMixin<AutocompleteField<QueryT, ResultT, CandidateT>> {
34-
AutocompleteView<QueryT, ResultT, CandidateT>? _viewModel;
34+
AutocompleteView<QueryT, ResultT>? _viewModel;
3535

3636
void _initViewModel() {
3737
_viewModel = widget.initViewModel(context)

0 commit comments

Comments
 (0)