Skip to content

Commit 72f0fd7

Browse files
committed
msglist [nfc]: Add some TODO(#95)s
1 parent c0a75d0 commit 72f0fd7

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

lib/widgets/message_list.dart

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -475,6 +475,7 @@ class MarkAsReadWidget extends StatelessWidget {
475475
padding: const EdgeInsets.symmetric(horizontal: 10, vertical: 10 - ((48 - 38) / 2)),
476476
child: FilledButton.icon(
477477
style: FilledButton.styleFrom(
478+
// TODO(#95) need dark-theme colors (foreground and background)
478479
backgroundColor: _UnreadMarker.color,
479480
minimumSize: const Size.fromHeight(38),
480481
textStyle:
@@ -519,6 +520,9 @@ class DateSeparator extends StatelessWidget {
519520

520521
final Message message;
521522

523+
// TODO(#95) in dark theme, use white, following web
524+
static const _line = BorderSide(width: 0, color: Colors.black);
525+
522526
@override
523527
Widget build(BuildContext context) {
524528
// This makes the small-caps text vertically centered,
@@ -534,9 +538,7 @@ class DateSeparator extends StatelessWidget {
534538
child: DecoratedBox(
535539
decoration: BoxDecoration(
536540
border: Border(
537-
bottom: BorderSide(
538-
width: 0,
539-
color: Colors.black)))))),
541+
bottom: _line))))),
540542
Padding(padding: const EdgeInsets.fromLTRB(2, 0, 2, textBottomPadding),
541543
child: DateText(
542544
fontSize: 16,
@@ -546,9 +548,7 @@ class DateSeparator extends StatelessWidget {
546548
child: DecoratedBox(
547549
decoration: BoxDecoration(
548550
border: Border(
549-
bottom: BorderSide(
550-
width: 0,
551-
color: Colors.black)))))
551+
bottom: _line)))),
552552
])),
553553
);
554554
}
@@ -881,6 +881,7 @@ class MessageWithPossibleSender extends StatelessWidget {
881881

882882
final MessageListMessageItem item;
883883

884+
// TODO(#95) unchanged in dark theme?
884885
static final _starColor = const HSLColor.fromAHSL(0.5, 47, 1, 0.41).toColor();
885886

886887
@override
@@ -973,6 +974,7 @@ class MessageWithPossibleSender extends StatelessWidget {
973974
// TODO web seems to ignore locale in formatting time, but we could do better
974975
final _kMessageTimestampFormat = DateFormat('h:mm aa', 'en_US');
975976

977+
// TODO(#95) need dark-theme color (this one comes from the Figma)
976978
final _kMessageTimestampColor = const HSLColor.fromAHSL(1, 0, 0, 0.5).toColor();
977979

978980
Future<void> markNarrowAsRead(

0 commit comments

Comments
 (0)