inbox: Display realmEmptyTopicDisplayName on empty topic

Signed-off-by: Zixuan James Li <[email protected]>

Author: PIG208

lib/widgets/inbox.dart

@@ -526,13 +526,16 @@ class _TopicItem extends StatelessWidget {
               child: Text(
                 style: TextStyle(
                   fontSize: 17,
+                  // ignore: unnecessary_null_comparison // null topic names soon to be enabled
+                  fontStyle: (topic.displayName == null) ? null : FontStyle.italic,
                   height: (20 / 17),
                   // TODO(design) check if this is the right variable
                   color: designVariables.labelMenuButton,
                 ),
                 maxLines: 2,
                 overflow: TextOverflow.ellipsis,
-                topic.displayName))),
+                // ignore: dead_null_aware_expression // null topic names soon to be enabled
+                topic.displayName ?? store.realmEmptyTopicDisplayName))),
             const SizedBox(width: 12),
             if (hasMention) const _IconMarker(icon: ZulipIcons.at_sign),
             // TODO(design) copies the "@" marker color; is there a better color?

test/widgets/inbox_test.dart

@@ -305,6 +305,20 @@ void main() {
       });
     });
 
+    group('general chat', () {
+      final channel = eg.stream();
+      final subscription = eg.subscription(channel);
+
+      testWidgets('show general chat', (tester) async {
+        await setupPage(tester,
+          streams: [channel],
+          subscriptions: [subscription],
+          unreadMessages: [eg.streamMessage(stream: channel, topic: '')]);
+
+        check(find.text(eg.defaultRealmEmptyTopicDisplayName)).findsOne();
+      }, skip: true); // null topic names soon to be enabled
+    });
+
     group('topic visibility', () {
       final channel = eg.stream();
       const topic = 'topic';