msglist [nfc]: s/maybeUpdateMessageFlags/handleUpdateMessageFlagsEvent/

Author: chrisbobbe

lib/model/message.dart

@@ -134,7 +134,7 @@ class MessageStoreImpl with MessageStore {
 
   void handleUpdateMessageFlagsEvent(UpdateMessageFlagsEvent event) {
     for (final view in _messageListViews) {
-      view.maybeUpdateMessageFlags(event); // TODO update mainly in [messages] instead
+      view.handleUpdateMessageFlagsEvent(event); // TODO update mainly in [messages] instead
     }
   }
 

lib/model/message_list.dart

@@ -460,7 +460,7 @@ class MessageListView with ChangeNotifier, _MessageSequence {
     }
   }
 
-  void maybeUpdateMessageFlags(UpdateMessageFlagsEvent event) {
+  void handleUpdateMessageFlagsEvent(UpdateMessageFlagsEvent event) {
     final isAdd = switch (event) {
       UpdateMessageFlagsAddEvent()    => true,
       UpdateMessageFlagsRemoveEvent() => false,

test/model/message_list_test.dart

@@ -330,7 +330,7 @@ void main() {
     });
   });
 
-  group('maybeUpdateMessageFlags', () {
+  group('handleUpdateMessageFlagsEvent', () {
     UpdateMessageFlagsAddEvent mkAddEvent(
       MessageFlag flag,
       List<int> messageIds, {
@@ -351,7 +351,7 @@ void main() {
         await prepare();
         final message = eg.streamMessage(flags: []);
         await prepareMessages(foundOldest: true, messages: [message]);
-        model.maybeUpdateMessageFlags(mkAddEvent(MessageFlag.read, [2]));
+        model.handleUpdateMessageFlagsEvent(mkAddEvent(MessageFlag.read, [2]));
         checkNotNotified();
         check(model).messages.single.flags.deepEquals([]);
       });
@@ -361,7 +361,7 @@ void main() {
         final message1 = eg.streamMessage(flags: []);
         final message2 = eg.streamMessage(flags: []);
         await prepareMessages(foundOldest: true, messages: [message1, message2]);
-        model.maybeUpdateMessageFlags(mkAddEvent(MessageFlag.read, [message2.id, 3]));
+        model.handleUpdateMessageFlagsEvent(mkAddEvent(MessageFlag.read, [message2.id, 3]));
         checkNotifiedOnce();
         check(model).messages
           ..[0].flags.deepEquals([])
@@ -373,7 +373,7 @@ void main() {
         final message1 = eg.streamMessage(flags: []);
         final message2 = eg.streamMessage(flags: []);
         await prepareMessages(foundOldest: true, messages: [message1, message2]);
-        model.maybeUpdateMessageFlags(mkAddEvent(MessageFlag.read, [], all: true));
+        model.handleUpdateMessageFlagsEvent(mkAddEvent(MessageFlag.read, [], all: true));
         checkNotifiedOnce();
         check(model).messages
           ..[0].flags.deepEquals([MessageFlag.read])
@@ -383,15 +383,15 @@ void main() {
       test('all: true, list empty', () async {
         await prepare();
         await prepareMessages(foundOldest: true, messages: []);
-        model.maybeUpdateMessageFlags(mkAddEvent(MessageFlag.read, [], all: true));
+        model.handleUpdateMessageFlagsEvent(mkAddEvent(MessageFlag.read, [], all: true));
         checkNotNotified();
       });
 
       test('other flags not clobbered', () async {
         final message = eg.streamMessage(flags: [MessageFlag.starred]);
         await prepare();
         await prepareMessages(foundOldest: true, messages: [message]);
-        model.maybeUpdateMessageFlags(mkAddEvent(MessageFlag.read, [message.id]));
+        model.handleUpdateMessageFlagsEvent(mkAddEvent(MessageFlag.read, [message.id]));
         checkNotifiedOnce();
         check(model).messages.single.flags.deepEquals([MessageFlag.starred, MessageFlag.read]);
       });
@@ -402,7 +402,7 @@ void main() {
         await prepare();
         final message = eg.streamMessage(flags: [MessageFlag.read]);
         await prepareMessages(foundOldest: true, messages: [message]);
-        model.maybeUpdateMessageFlags(mkAddEvent(MessageFlag.read, [2]));
+        model.handleUpdateMessageFlagsEvent(mkAddEvent(MessageFlag.read, [2]));
         checkNotNotified();
         check(model).messages.single.flags.deepEquals([MessageFlag.read]);
       });
@@ -413,7 +413,7 @@ void main() {
         final message2 = eg.streamMessage(flags: [MessageFlag.read]);
         final message3 = eg.streamMessage(flags: [MessageFlag.read]);
         await prepareMessages(foundOldest: true, messages: [message1, message2]);
-        model.maybeUpdateMessageFlags(mkRemoveEvent(MessageFlag.read, [message2, message3]));
+        model.handleUpdateMessageFlagsEvent(mkRemoveEvent(MessageFlag.read, [message2, message3]));
         checkNotifiedOnce();
         check(model).messages
           ..[0].flags.deepEquals([MessageFlag.read])
@@ -424,7 +424,7 @@ void main() {
         final message = eg.streamMessage(flags: [MessageFlag.starred, MessageFlag.read]);
         await prepare();
         await prepareMessages(foundOldest: true, messages: [message]);
-        model.maybeUpdateMessageFlags(mkRemoveEvent(MessageFlag.read, [message]));
+        model.handleUpdateMessageFlagsEvent(mkRemoveEvent(MessageFlag.read, [message]));
         checkNotifiedOnce();
         check(model).messages.single.flags.deepEquals([MessageFlag.starred]);
       });