Skip to content

Commit 8626061

Browse files
committed
msglist [nfc]: Place _allMessagesVisible right after _messageVisible
This is solely for a better order.
1 parent ad232ad commit 8626061

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

lib/model/message_list.dart

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -478,39 +478,39 @@ class MessageListView with ChangeNotifier, _MessageSequence {
478478
}
479479
}
480480

481-
/// Whether this event could affect the result that [_messageVisible]
482-
/// would ever have returned for any possible message in this message list.
483-
VisibilityEffect _canAffectVisibility(UserTopicEvent event) {
481+
/// Whether [_messageVisible] is true for all possible messages.
482+
///
483+
/// This is useful for an optimization.
484+
bool get _allMessagesVisible {
484485
switch (narrow) {
485486
case CombinedFeedNarrow():
486-
return store.willChangeIfTopicVisible(event);
487-
488-
case ChannelNarrow(:final streamId):
489-
if (event.streamId != streamId) return VisibilityEffect.none;
490-
return store.willChangeIfTopicVisibleInStream(event);
487+
case ChannelNarrow():
488+
return false;
491489

492490
case TopicNarrow():
493491
case DmNarrow():
494492
case MentionsNarrow():
495493
case StarredMessagesNarrow():
496-
return VisibilityEffect.none;
494+
return true;
497495
}
498496
}
499497

500-
/// Whether [_messageVisible] is true for all possible messages.
501-
///
502-
/// This is useful for an optimization.
503-
bool get _allMessagesVisible {
498+
/// Whether this event could affect the result that [_messageVisible]
499+
/// would ever have returned for any possible message in this message list.
500+
VisibilityEffect _canAffectVisibility(UserTopicEvent event) {
504501
switch (narrow) {
505502
case CombinedFeedNarrow():
506-
case ChannelNarrow():
507-
return false;
503+
return store.willChangeIfTopicVisible(event);
504+
505+
case ChannelNarrow(:final streamId):
506+
if (event.streamId != streamId) return VisibilityEffect.none;
507+
return store.willChangeIfTopicVisibleInStream(event);
508508

509509
case TopicNarrow():
510510
case DmNarrow():
511511
case MentionsNarrow():
512512
case StarredMessagesNarrow():
513-
return true;
513+
return VisibilityEffect.none;
514514
}
515515
}
516516

0 commit comments

Comments
 (0)