Skip to content

Commit 954ce5a

Browse files
committed
msglist [nfc]: s/maybeUpdateMessage/handleUpdateMessageEvent/
1 parent 6e4c1e0 commit 954ce5a

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

lib/model/message.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class MessageStoreImpl with MessageStore {
9494

9595
void handleUpdateMessageEvent(UpdateMessageEvent event) {
9696
for (final view in _messageListViews) {
97-
view.maybeUpdateMessage(event); // TODO update mainly in [messages] instead
97+
view.handleUpdateMessageEvent(event); // TODO update mainly in [messages] instead
9898
}
9999
}
100100

lib/model/message_list.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,7 @@ class MessageListView with ChangeNotifier, _MessageSequence {
483483
/// TODO(#150): Handle message moves.
484484
// NB that when handling message moves (#150), recipient headers
485485
// may need updating, and consequently showSender too.
486-
void maybeUpdateMessage(UpdateMessageEvent event) {
486+
void handleUpdateMessageEvent(UpdateMessageEvent event) {
487487
final idx = _findMessageWithId(event.messageId);
488488
if (idx == -1) {
489489
return;

test/model/message_list_test.dart

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ void main() {
297297
});
298298
});
299299

300-
group('maybeUpdateMessage', () {
300+
group('handleUpdateMessageEvent', () {
301301
test('update a message', () async {
302302
final originalMessage = eg.streamMessage(
303303
content: "<p>Hello, world</p>");
@@ -317,7 +317,7 @@ void main() {
317317
..flags.not((it) => it.deepEquals(updateEvent.flags))
318318
..isMeMessage.not((it) => it.equals(updateEvent.isMeMessage!));
319319

320-
model.maybeUpdateMessage(updateEvent);
320+
model.handleUpdateMessageEvent(updateEvent);
321321
checkNotifiedOnce();
322322
check(model).messages.single
323323
..identicalTo(message)
@@ -337,7 +337,7 @@ void main() {
337337
await prepare();
338338
await prepareMessages(foundOldest: true, messages: [originalMessage]);
339339

340-
model.maybeUpdateMessage(updateEvent);
340+
model.handleUpdateMessageEvent(updateEvent);
341341
checkNotNotified();
342342
check(model).messages.single
343343
..content.equals(originalMessage.content)
@@ -359,7 +359,7 @@ void main() {
359359
await prepareMessages(foundOldest: true, messages: [originalMessage]);
360360
final message = model.messages.single;
361361

362-
model.maybeUpdateMessage(updateEvent);
362+
model.handleUpdateMessageEvent(updateEvent);
363363
checkNotifiedOnce();
364364
check(model).messages.single
365365
..identicalTo(message)
@@ -813,17 +813,17 @@ void main() {
813813
await store.handleEvent(MessageEvent(id: 0, message: streamMessage(14)));
814814
checkNotifiedOnce();
815815

816-
// Then test maybeUpdateMessage, where a header is and remains needed…
816+
// Then test handleUpdateMessageEvent, where a header is and remains needed…
817817
UpdateMessageEvent updateEvent(Message message) => eg.updateMessageEditEvent(
818818
message, renderedContent: '${message.content}<p>edited</p>',
819819
);
820-
model.maybeUpdateMessage(updateEvent(model.messages.first));
820+
model.handleUpdateMessageEvent(updateEvent(model.messages.first));
821821
checkNotifiedOnce();
822-
model.maybeUpdateMessage(updateEvent(model.messages[model.messages.length - 2]));
822+
model.handleUpdateMessageEvent(updateEvent(model.messages[model.messages.length - 2]));
823823
checkNotifiedOnce();
824824

825825
// … and where it's not.
826-
model.maybeUpdateMessage(updateEvent(model.messages.last));
826+
model.handleUpdateMessageEvent(updateEvent(model.messages.last));
827827
checkNotifiedOnce();
828828

829829
// Then test reassemble.

0 commit comments

Comments
 (0)