store [nfc]: Add GlobalStore reference on PerAccountStore

Author: gnprice

lib/model/store.dart

@@ -150,12 +150,14 @@ abstract class GlobalStore extends ChangeNotifier {
 /// [UpdateMachine].
 class PerAccountStore extends ChangeNotifier with StreamStore {
   factory PerAccountStore.fromInitialSnapshot({
+    required GlobalStore globalStore,
     required Account account,
     required ApiConnection connection,
     required InitialSnapshot initialSnapshot,
   }) {
     final streams = StreamStoreImpl(initialSnapshot: initialSnapshot);
     return PerAccountStore._(
+      globalStore: globalStore,
       account: account,
       connection: connection,
       zulipVersion: initialSnapshot.zulipVersion,
@@ -181,6 +183,7 @@ class PerAccountStore extends ChangeNotifier with StreamStore {
   }
 
   PerAccountStore._({
+    required GlobalStore globalStore,
     required this.account,
     required this.connection,
     required this.zulipVersion,
@@ -193,7 +196,12 @@ class PerAccountStore extends ChangeNotifier with StreamStore {
     required this.users,
     required streams,
     required this.recentDmConversationsView,
-  }) : _streams = streams;
+  }) : _globalStore = globalStore,
+       _streams = streams;
+
+  // We'll use this in an upcoming commit.
+  // ignore: unused_field
+  final GlobalStore _globalStore;
 
   final Account account;
   final ApiConnection connection; // TODO(#135): update zulipFeatureLevel with events
@@ -453,7 +461,7 @@ class LiveGlobalStore extends GlobalStore {
 
   @override
   Future<PerAccountStore> loadPerAccount(Account account) async {
-    final updateMachine = await UpdateMachine.load(account);
+    final updateMachine = await UpdateMachine.load(this, account);
     return updateMachine.store;
   }
 
@@ -491,7 +499,7 @@ class UpdateMachine {
   /// Load the user's data from the server, and start an event queue going.
   ///
   /// In the future this might load an old snapshot from local storage first.
-  static Future<UpdateMachine> load(Account account) async {
+  static Future<UpdateMachine> load(GlobalStore globalStore, Account account) async {
     final connection = ApiConnection.live(
       realmUrl: account.realmUrl, zulipFeatureLevel: account.zulipFeatureLevel,
       email: account.email, apiKey: account.apiKey);
@@ -503,6 +511,7 @@ class UpdateMachine {
     if (kDebugMode) print("initial fetch time: ${t.inMilliseconds}ms");
 
     final store = PerAccountStore.fromInitialSnapshot(
+      globalStore: globalStore,
       account: account,
       connection: connection,
       initialSnapshot: initialSnapshot,

test/example_data.dart

@@ -7,6 +7,7 @@ import 'package:zulip/model/narrow.dart';
 import 'package:zulip/model/store.dart';
 
 import 'api/fake_api.dart';
+import 'model/test_store.dart';
 import 'stdlib_checks.dart';
 
 ////////////////////////////////////////////////////////////////
@@ -414,9 +415,13 @@ UpdateMessageFlagsRemoveEvent updateMessageFlagsRemoveEvent(
 }
 
 ////////////////////////////////////////////////////////////////
-// The entire per-account state.
+// The entire per-account or global state.
 //
 
+GlobalStore globalStore({List<Account> accounts = const []}) {
+  return TestGlobalStore(accounts: accounts);
+}
+
 InitialSnapshot initialSnapshot({
   String? queueId,
   int? lastEventId,
@@ -467,9 +472,11 @@ InitialSnapshot initialSnapshot({
 const _initialSnapshot = initialSnapshot;
 
 PerAccountStore store({Account? account, InitialSnapshot? initialSnapshot}) {
+  final effectiveAccount = account ?? selfAccount;
   return PerAccountStore.fromInitialSnapshot(
-    account: account ?? selfAccount,
-    connection: FakeApiConnection.fromAccount(account ?? selfAccount),
+    globalStore: globalStore(accounts: [effectiveAccount]),
+    account: effectiveAccount,
+    connection: FakeApiConnection.fromAccount(effectiveAccount),
     initialSnapshot: initialSnapshot ?? _initialSnapshot(),
   );
 }

test/model/store_test.dart

@@ -31,6 +31,7 @@ void main() {
 
     final future1 = globalStore.perAccount(1);
     final store1 = PerAccountStore.fromInitialSnapshot(
+      globalStore: globalStore,
       account: account1,
       connection: FakeApiConnection.fromAccount(account1),
       initialSnapshot: eg.initialSnapshot(),
@@ -42,6 +43,7 @@ void main() {
 
     final future2 = globalStore.perAccount(2);
     final store2 = PerAccountStore.fromInitialSnapshot(
+      globalStore: globalStore,
       account: account2,
       connection: FakeApiConnection.fromAccount(account2),
       initialSnapshot: eg.initialSnapshot(),
@@ -69,11 +71,13 @@ void main() {
 
     final future2 = globalStore.perAccount(2);
     final store1 = PerAccountStore.fromInitialSnapshot(
+      globalStore: globalStore,
       account: account1,
       connection: FakeApiConnection.fromAccount(account1),
       initialSnapshot: eg.initialSnapshot(),
     );
     final store2 = PerAccountStore.fromInitialSnapshot(
+      globalStore: globalStore,
       account: account2,
       connection: FakeApiConnection.fromAccount(account2),
       initialSnapshot: eg.initialSnapshot(),
@@ -99,6 +103,7 @@ void main() {
     final future1 = globalStore.perAccount(1);
     check(globalStore.perAccountSync(1)).isNull();
     final store1 = PerAccountStore.fromInitialSnapshot(
+      globalStore: globalStore,
       account: account1,
       connection: FakeApiConnection.fromAccount(account1),
       initialSnapshot: eg.initialSnapshot(),

test/model/test_store.dart

@@ -51,6 +51,7 @@ class TestGlobalStore extends GlobalStore {
   @override
   Future<PerAccountStore> loadPerAccount(Account account) {
     return Future.value(PerAccountStore.fromInitialSnapshot(
+      globalStore: this,
       account: account,
       connection: FakeApiConnection.fromAccount(account),
       initialSnapshot: _initialSnapshots[account.id]!,