autocomplete [nfc]: Factor out AutocompleteDataProvider

`AutocompleteDataProvider` provides the full list of possible items
and filter predicate for `AutocompleteView` without having to deal
with state management or result computation process.

With this factored out of `AutocompleteView` it's responsibility is
limited to only managing the autocomplete state.

While fetching data and setting the logic on passing items to query
filter is the responsibility of `AutocompleteDataProvider`.

Author: Khader-1

lib/model/autocomplete.dart

@@ -151,6 +151,20 @@ class AutocompleteViewManager {
   // void dispose() { … }
 }
 
+/// Provides the full list of possible items and filter predicate for
+/// `AutocompleteView` without having to deal with state management or
+/// result computation process.
+///
+/// Having this factored out of `AutocompleteView` helps in limiting
+/// it's responsibility to managing the autocomplete state and result
+/// computation process.
+abstract class AutocompleteDataProvider<T, Q extends AutocompleteQuery, R extends AutocompleteResult> {
+
+  Iterable<T> getDataForQuery(Q query);
+
+  R? testItem(Q query, T item);
+}
+
 /// A view-model for an autocomplete interaction.
 ///
 /// The owner of one of these objects must call [dispose] when the object
@@ -164,17 +178,14 @@ class AutocompleteViewManager {
 ///  * When the object will no longer be used, call [dispose] to free
 ///    resources on the [PerAccountStore].
 abstract class AutocompleteView<Q extends AutocompleteQuery, R extends AutocompleteResult> extends ChangeNotifier {
+  final AutocompleteDataProvider<Object, Q, R> dataProvider;
 
   /// This could be used to transform results after they've been
   /// computed for sorting, filtering etc.
   final List<R> Function(List<R> results)? resultsFilter;
   final PerAccountStore store;
 
-  AutocompleteView({this.resultsFilter, required this.store});
-
-  Iterable<Object> getDataForQuery(Q query);
-
-  R? testItem(Q query, Object item);
+  AutocompleteView({required this.dataProvider, this.resultsFilter, required this.store});
 
   Q? get query => _query;
   Q? _query;
@@ -221,7 +232,7 @@ abstract class AutocompleteView<Q extends AutocompleteQuery, R extends Autocompl
 
   Future<List<R>?> _computeResults(Q query) async {
     final List<R> results = [];
-    final Iterable<Object> data = getDataForQuery(query);
+    final Iterable<Object> data = dataProvider.getDataForQuery(query);
 
     final iterator = data.iterator;
     bool isDone = false;
@@ -238,25 +249,22 @@ abstract class AutocompleteView<Q extends AutocompleteQuery, R extends Autocompl
           isDone = true;
           break;
         }
-        final Object item = iterator.current;
-        final result = testItem(query, item);
+        final result = dataProvider.testItem(query, iterator.current);
         if (result != null) results.add(result);
       }
     }
     return resultsFilter?.call(results) ?? results;
   }
 }
 
-class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery, MentionAutocompleteResult> {
+class MentionAutocompleteDataProvider extends AutocompleteDataProvider<Object, MentionAutocompleteQuery, MentionAutocompleteResult> {
   final Narrow narrow;
+  final PerAccountStore store;
 
-  MentionAutocompleteView.init({
-    required super.store,
-    required this.narrow,
-  }) : sortedUsers = _usersByRelevance(store: store, narrow: narrow)
-  {
-    store.autocompleteViewManager.registerMentionAutocomplete(this);
-  }
+  MentionAutocompleteDataProvider({
+    required this.store,
+    required this.narrow
+  }) : sortedUsers = _usersByRelevance(store: store, narrow: narrow);
 
   final List<User> sortedUsers;
 
@@ -303,6 +311,18 @@ class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery,
       _              => 0,
     };
   }
+}
+
+class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery, MentionAutocompleteResult> {
+
+  MentionAutocompleteView.init({
+    required super.store,
+    required Narrow narrow,
+  }) : super(dataProvider: MentionAutocompleteDataProvider(
+    store: store,
+    narrow: narrow)) {
+    store.autocompleteViewManager.registerMentionAutocomplete(this);
+  }
 
   @override
   void dispose() {

test/model/autocomplete_test.dart

@@ -368,7 +368,7 @@ void main() {
       const idA = 1;
       const idB = 2;
 
-      int compareAB() => MentionAutocompleteView.compareByDms(
+      int compareAB() => MentionAutocompleteDataProvider.compareByDms(
         eg.user(userId: idA),
         eg.user(userId: idB),
         store: store,