Skip to content

Commit c64d7a0

Browse files
chrisbobbegnprice
authored andcommitted
unread_count_badge: Comment on some overlooked uncertainty in text color
1 parent 0fd8924 commit c64d7a0

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

lib/widgets/unread_count_badge.dart

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,16 @@ class UnreadCountBadge extends StatelessWidget {
4747
fontSize: 16,
4848
height: (18 / 16),
4949
fontFeatures: [FontFeature.enable('smcp')], // small caps
50+
51+
// From the Figma:
52+
// https://www.figma.com/file/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?type=design&node-id=171-12359&mode=design&t=JKrw76SGUF51nSJG-0
53+
// TODO or, when background is stream-colored, follow Vlad's replit?
54+
// https://replit.com/@VladKorobov/zulip-sidebar#script.js
55+
// which would mean:
56+
// - in light mode use `Color.fromRGBO(0, 0, 0, 0.9)`
57+
// - in dark mode use `Color.fromRGBO(255, 255, 255, 0.9)`
58+
// The web app doesn't (yet?) use stream-colored unread markers
59+
// so we can't take direction from there.
5060
color: Color(0xFF222222),
5161
).merge(weightVariableTextStyle(context,
5262
wght: bold ? 600 : null)),

0 commit comments

Comments
 (0)