Skip to content

Commit dbc3488

Browse files
committed
home test [nfc]: Move testNavObserver out to main
This will be useful for some other tests.
1 parent a4b5abb commit dbc3488

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

test/widgets/home_test.dart

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,22 @@ void main () {
3333

3434
late PerAccountStore store;
3535
late FakeApiConnection connection;
36+
late List<Route<dynamic>> pushedRoutes;
3637

37-
Future<void> prepare(WidgetTester tester, {
38-
NavigatorObserver? navigatorObserver,
39-
}) async {
38+
final testNavObserver = TestNavigatorObserver()
39+
..onPushed = (route, prevRoute) => pushedRoutes.add(route);
40+
41+
Future<void> prepare(WidgetTester tester) async {
4042
addTearDown(testBinding.reset);
43+
pushedRoutes = [];
4144
await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot());
4245
store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
4346
connection = store.connection as FakeApiConnection;
4447
await store.addUser(eg.selfUser);
4548

4649
await tester.pumpWidget(TestZulipApp(
4750
accountId: eg.selfAccount.id,
48-
navigatorObservers: navigatorObserver != null ? [navigatorObserver] : [],
51+
navigatorObservers: [testNavObserver],
4952
child: const HomePage()));
5053
await tester.pump();
5154
}
@@ -118,10 +121,7 @@ void main () {
118121
});
119122

120123
testWidgets('combined feed', (tester) async {
121-
final pushedRoutes = <Route<dynamic>>[];
122-
final testNavObserver = TestNavigatorObserver()
123-
..onPushed = (route, prevRoute) => pushedRoutes.add(route);
124-
await prepare(tester, navigatorObserver: testNavObserver);
124+
await prepare(tester);
125125
pushedRoutes.clear();
126126

127127
connection.prepare(json: eg.newestGetMessagesResult(

0 commit comments

Comments
 (0)