Skip to content

Commit e55675e

Browse files
sm-sayedignprice
authored andcommitted
action-sheet: Rename CopyButton to CopyMessageTextButton
The reason for this renaming is to have a clear distinction between the existing "copy message text" and the upcoming "copy message link" buttons.
1 parent 1f97563 commit e55675e

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

assets/l10n/app_en.arb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@
4343
"@permissionsDeniedReadExternalStorage": {
4444
"description": "Message for dialog asking the user to grant permissions for external storage read access."
4545
},
46-
"actionSheetOptionCopy": "Copy message text",
47-
"@actionSheetOptionCopy": {
46+
"actionSheetOptionCopyMessageText": "Copy message text",
47+
"@actionSheetOptionCopyMessageText": {
4848
"description": "Label for copy message text button on action sheet."
4949
},
5050
"actionSheetOptionShare": "Share",
@@ -168,8 +168,8 @@
168168
"@successLinkCopied": {
169169
"description": "Success message after copy link action completed."
170170
},
171-
"successMessageCopied": "Message Copied",
172-
"@successMessageCopied": {
171+
"successMessageTextCopied": "Message text copied",
172+
"@successMessageTextCopied": {
173173
"description": "Message when content of a message was copied to the user's system clipboard."
174174
},
175175
"composeBoxAttachFilesTooltip": "Attach files",

lib/widgets/action_sheet.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ void showMessageActionSheet({required BuildContext context, required Message mes
4444
message: message,
4545
messageListContext: context,
4646
),
47-
CopyButton(message: message, messageListContext: context),
47+
CopyMessageTextButton(message: message, messageListContext: context),
4848
]);
4949
});
5050
}
@@ -330,8 +330,8 @@ class QuoteAndReplyButton extends MessageActionSheetMenuItemButton {
330330
}
331331
}
332332

333-
class CopyButton extends MessageActionSheetMenuItemButton {
334-
CopyButton({
333+
class CopyMessageTextButton extends MessageActionSheetMenuItemButton {
334+
CopyMessageTextButton({
335335
super.key,
336336
required super.message,
337337
required super.messageListContext,
@@ -341,7 +341,7 @@ class CopyButton extends MessageActionSheetMenuItemButton {
341341

342342
@override
343343
String label(ZulipLocalizations zulipLocalizations) {
344-
return zulipLocalizations.actionSheetOptionCopy;
344+
return zulipLocalizations.actionSheetOptionCopyMessageText;
345345
}
346346

347347
@override void onPressed(BuildContext context) async {
@@ -362,7 +362,7 @@ class CopyButton extends MessageActionSheetMenuItemButton {
362362
if (!messageListContext.mounted) return;
363363

364364
copyWithPopup(context: context,
365-
successContent: Text(zulipLocalizations.successMessageCopied),
365+
successContent: Text(zulipLocalizations.successMessageTextCopied),
366366
data: ClipboardData(text: rawContent));
367367
}
368368
}

test/widgets/action_sheet_test.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -449,15 +449,15 @@ void main() {
449449
});
450450
});
451451

452-
group('CopyButton', () {
452+
group('CopyMessageTextButton', () {
453453
setUp(() async {
454454
TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger.setMockMethodCallHandler(
455455
SystemChannels.platform,
456456
MockClipboard().handleMethodCall,
457457
);
458458
});
459459

460-
Future<void> tapCopyButton(WidgetTester tester) async {
460+
Future<void> tapCopyMessageTextButton(WidgetTester tester) async {
461461
await tester.ensureVisible(find.byIcon(Icons.copy, skipOffstage: false));
462462
await tester.tap(find.byIcon(Icons.copy));
463463
await tester.pump(); // [MenuItemButton.onPressed] called in a post-frame callback: flutter/flutter@e4a39fa2e
@@ -469,7 +469,7 @@ void main() {
469469
final store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
470470

471471
prepareRawContentResponseSuccess(store, message: message, rawContent: 'Hello world');
472-
await tapCopyButton(tester);
472+
await tapCopyMessageTextButton(tester);
473473
await tester.pump(Duration.zero);
474474
check(await Clipboard.getData('text/plain')).isNotNull().text.equals('Hello world');
475475
});
@@ -480,7 +480,7 @@ void main() {
480480
final store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
481481

482482
prepareRawContentResponseError(store);
483-
await tapCopyButton(tester);
483+
await tapCopyMessageTextButton(tester);
484484
await tester.pump(Duration.zero); // error arrives; error dialog shows
485485

486486
await tester.tap(find.byWidget(checkErrorDialog(tester,

0 commit comments

Comments
 (0)