test [nfc]: Make addUsers async

This is the next step toward making handleEvent async.

Author: gnprice

test/model/autocomplete_test.dart

@@ -167,8 +167,8 @@ void main() {
 
   test('MentionAutocompleteView misc', () async {
     const narrow = AllMessagesNarrow();
-    final store = eg.store()
-      ..addUsers([eg.selfUser, eg.otherUser, eg.thirdUser]);
+    final store = eg.store();
+    await store.addUsers([eg.selfUser, eg.otherUser, eg.thirdUser]);
     final view = MentionAutocompleteView.init(store: store, narrow: narrow);
 
     bool done = false;
@@ -182,10 +182,10 @@ void main() {
   });
 
   test('MentionAutocompleteView not starve timers', () {
-    fakeAsync((binding) {
+    fakeAsync((binding) async {
       const narrow = AllMessagesNarrow();
-      final store = eg.store()
-        ..addUsers([eg.selfUser, eg.otherUser, eg.thirdUser]);
+      final store = eg.store();
+      await store.addUsers([eg.selfUser, eg.otherUser, eg.thirdUser]);
       final view = MentionAutocompleteView.init(store: store, narrow: narrow);
 
       bool searchDone = false;

test/model/compose_test.dart

@@ -311,19 +311,19 @@ hello
     test('silent', () {
       check(mention(user, silent: true)).equals('@_**Full Name|123**');
     });
-    test('`users` passed; has two users with same fullName', () {
+    test('`users` passed; has two users with same fullName', () async {
       final store = eg.store();
-      store.addUsers([user, eg.user(userId: 5), eg.user(userId: 234, fullName: user.fullName)]);
+      await store.addUsers([user, eg.user(userId: 5), eg.user(userId: 234, fullName: user.fullName)]);
       check(mention(user, silent: true, users: store.users)).equals('@_**Full Name|123**');
     });
-    test('`users` passed; has two same-name users but one of them is deactivated', () {
+    test('`users` passed; has two same-name users but one of them is deactivated', () async {
       final store = eg.store();
-      store.addUsers([user, eg.user(userId: 5), eg.user(userId: 234, fullName: user.fullName, isActive: false)]);
+      await store.addUsers([user, eg.user(userId: 5), eg.user(userId: 234, fullName: user.fullName, isActive: false)]);
       check(mention(user, silent: true, users: store.users)).equals('@_**Full Name|123**');
     });
-    test('`users` passed; user has unique fullName', () {
+    test('`users` passed; user has unique fullName', () async {
       final store = eg.store();
-      store.addUsers([user, eg.user(userId: 234, fullName: 'Another Name')]);
+      await store.addUsers([user, eg.user(userId: 234, fullName: 'Another Name')]);
       check(mention(user, silent: true, users: store.users)).equals('@_**Full Name**');
     });
   });

test/model/internal_link_test.dart

@@ -9,19 +9,19 @@ import 'package:zulip/model/store.dart';
 import '../example_data.dart' as eg;
 import 'test_store.dart';
 
-PerAccountStore setupStore({
+Future<PerAccountStore> setupStore({
   required Uri realmUrl,
   List<ZulipStream>? streams,
   List<User>? users,
-}) {
+}) async {
   final account = eg.selfAccount.copyWith(realmUrl: realmUrl);
   final store = eg.store(account: account);
   if (streams != null) {
     store.addStreams(streams);
   }
   store.addUser(eg.selfUser);
   if (users != null) {
-    store.addUsers(users);
+    await store.addUsers(users);
   }
   return store;
 }
@@ -37,8 +37,8 @@ void main() {
     for (final testCase in testCases) {
       final String urlString = testCase.$1;
       final Narrow? expected = testCase.$2;
-      test(urlString, () {
-        final store = setupStore(realmUrl: realmUrl, streams: streams, users: users);
+      test(urlString, () async {
+        final store = await setupStore(realmUrl: realmUrl, streams: streams, users: users);
         final url = store.tryResolveUrl(urlString)!;
         check(parseInternalLink(url, store)).equals(expected);
       });
@@ -131,8 +131,8 @@ void main() {
       final String description = testCase.$2;
       final String urlString = testCase.$3;
       final Uri realmUrl = testCase.$4;
-      test('${expected ? 'accepts': 'rejects'} $description: $urlString', () {
-        final store = setupStore(realmUrl: realmUrl, streams: streams);
+      test('${expected ? 'accepts': 'rejects'} $description: $urlString', () async {
+        final store = await setupStore(realmUrl: realmUrl, streams: streams);
         final url = store.tryResolveUrl(urlString)!;
         final result = parseInternalLink(url, store);
         check(result != null).equals(expected);

test/model/test_store.dart

@@ -118,7 +118,7 @@ extension PerAccountStoreTestExtension on PerAccountStore {
     handleEvent(RealmUserAddEvent(id: 1, person: user));
   }
 
-  void addUsers(Iterable<User> users) {
+  Future<void> addUsers(Iterable<User> users) async {
     for (final user in users) {
       addUser(user);
     }

test/widgets/autocomplete_test.dart

@@ -31,8 +31,8 @@ Future<Finder> setupToComposeInput(WidgetTester tester, {
   addTearDown(testBinding.reset);
   await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot());
   final store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
-  store.addUsers([eg.selfUser, eg.otherUser]);
-  store.addUsers(users);
+  await store.addUsers([eg.selfUser, eg.otherUser]);
+  await store.addUsers(users);
   final connection = store.connection as FakeApiConnection;
 
   // prepare message list data

test/widgets/emoji_reaction_test.dart

@@ -101,16 +101,15 @@ void main() {
 
                 await prepare();
 
-                store
-                  ..addUsers(users)
-                  ..handleEvent(RealmEmojiUpdateEvent(id: 1,
-                      realmEmoji: realmEmoji))
-                  ..handleEvent(UserSettingsUpdateEvent(id: 1,
-                      property: UserSettingName.displayEmojiReactionUsers,
-                      value: displayEmojiReactionUsers))
-                  ..handleEvent(UserSettingsUpdateEvent(id: 1,
-                      property: UserSettingName.emojiset,
-                      value: emojiset));
+                await store.addUsers(users);
+                store.handleEvent(RealmEmojiUpdateEvent(id: 1,
+                  realmEmoji: realmEmoji));
+                store.handleEvent(UserSettingsUpdateEvent(id: 1,
+                  property: UserSettingName.displayEmojiReactionUsers,
+                  value: displayEmojiReactionUsers));
+                store.handleEvent(UserSettingsUpdateEvent(id: 1,
+                  property: UserSettingName.emojiset,
+                  value: emojiset));
 
                 // This does mean that all image emoji will look the same…
                 // shrug, at least for now.

test/widgets/inbox_test.dart

@@ -61,10 +61,9 @@ void main() {
     await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot());
     store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
 
-    store
-      ..addStreams(streams ?? [])
-      ..addSubscriptions(subscriptions ?? [])
-      ..addUsers(users ?? [eg.selfUser]);
+    store.addStreams(streams ?? []);
+    store.addSubscriptions(subscriptions ?? []);
+    await store.addUsers(users ?? [eg.selfUser]);
 
     for (final message in unreadMessages) {
       assert(!message.flags.contains(MessageFlag.read));

test/widgets/message_list_test.dart

@@ -58,7 +58,7 @@ void main() {
 
     // prepare message list data
     store.addUser(eg.selfUser);
-    store.addUsers(users ?? []);
+    await store.addUsers(users ?? []);
     assert((messageCount == null) != (messages == null));
     messages ??= List.generate(messageCount!, (index) {
       return eg.streamMessage(sender: eg.selfUser);

test/widgets/profile_test.dart

@@ -37,7 +37,7 @@ Future<void> setupPage(WidgetTester tester, {
 
   store.addUser(eg.selfUser);
   if (users != null) {
-    store.addUsers(users);
+    await store.addUsers(users);
   }
 
   await tester.pumpWidget(