action_sheet: translations

Author: sirpengi

assets/l10n/app_en.arb

@@ -43,6 +43,38 @@
   "@cameraAccessDeniedButtonText": {
     "description": "Message for dialog when the user needs to grant permissions for camera access."
   },
+  "actionSheetCopyMessageText": "Copy message text",
+  "@actionSheetCopyMessageText":  {
+    "description": "Label for copy message text button on action sheet."
+  },
+  "actionSheetCouldNotFetchMessageSource": "Could not fetch message source",
+  "@actionSheetCouldNotFetchMessageSource": {
+    "description": "Dialog message when the source of a message could not be fetched."
+  },
+  "actionSheetCopyingFailed": "Copying failed",
+  "@actionSheetCopyingFailed": {
+    "description": "Dialog message when copying the text of a message to the users system clipboard failed."
+  },
+  "actionSheetMessageCopied": "Message Copied",
+  "@actionSheetMessageCopied": {
+    "description": "Dialog message when content of a message was copied to the users system clipboard."
+  },
+  "actionSheetMessageDoesNotSeemToExist": "That message does not seem to exist.",
+  "@actionSheetMessageDoesNotSeemToExist": {
+    "description": "Dialog message in action sheet when loading a message that does not exist."
+  },
+  "actionSheetQuoteAndReply": "Quote and reply",
+  "@actionSheetQuoteAndReply":  {
+    "description": "Label for Quote and reply button on action sheet."
+  },
+  "actionSheetQuotationFailed": "Quotation failed",
+  "@actionSheetQuotationFailed": {
+    "description": "Error dialog message when quoting a message failed."
+  },
+  "actionSheetShare": "Share",
+  "@actionSheetShare":  {
+    "description": "Label for share button on action sheet."
+  },
   "subscribedToNStreams": "Subscribed to {num, plural, =0{no streams} =1{1 stream} other{{num} streams}}",
   "@subscribedToNStreams": {
     "description": "Test page label showing number of streams user is subscribed to.",

lib/widgets/action_sheet.dart

@@ -1,5 +1,6 @@
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
+import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
 import 'package:share_plus/share_plus.dart';
 
 import '../api/exception.dart';
@@ -43,18 +44,19 @@ abstract class MessageActionSheetMenuItemButton extends StatelessWidget {
   }) : assert(messageListContext.findAncestorWidgetOfExactType<MessageListPage>() != null);
 
   IconData get icon;
-  String get label;
+  String Function(ZulipLocalizations) get translateLabel;
   void Function(BuildContext) get onPressed;
 
   final Message message;
   final BuildContext messageListContext;
 
   @override
   Widget build(BuildContext context) {
+    final zulipLocalizations = ZulipLocalizations.of(context);
     return MenuItemButton(
       leadingIcon: Icon(icon),
       onPressed: () => onPressed(context),
-      child: Text(label));
+      child: Text(translateLabel(zulipLocalizations)));
   }
 }
 
@@ -67,7 +69,9 @@ class ShareButton extends MessageActionSheetMenuItemButton {
 
   @override get icon => Icons.adaptive.share;
 
-  @override get label => 'Share';
+  @override get translateLabel => (ZulipLocalizations zulipLocalizations) {
+    return zulipLocalizations.actionSheetShare;
+  };
 
   @override get onPressed => (BuildContext context) async {
     // Close the message action sheet; we're about to show the share
@@ -104,22 +108,23 @@ Future<String?> fetchRawContentWithFeedback({
     // - If request(s) take(s) a long time, show snackbar with cancel
     //   button, like "Still working on quote-and-reply…".
     //   On final failure or success, auto-dismiss the snackbar.
+    final zulipLocalizations = ZulipLocalizations.of(context);
     try {
       fetchedMessage = await getMessageCompat(PerAccountStoreWidget.of(context).connection,
         messageId: messageId,
         applyMarkdown: false,
       );
       if (fetchedMessage == null) {
-        errorMessage = 'That message does not seem to exist.';
+        errorMessage = zulipLocalizations.actionSheetMessageDoesNotSeemToExist;
       }
     } catch (e) {
       switch (e) {
         case ZulipApiException():
-          errorMessage = e.message;
+          errorMessage = e.toTranslatedString(zulipLocalizations);
         // TODO specific messages for common errors, like network errors
         //   (support with reusable code)
         default:
-          errorMessage = 'Could not fetch message source.';
+          errorMessage = zulipLocalizations.actionSheetCouldNotFetchMessageSource;
       }
     }
 
@@ -146,12 +151,15 @@ class QuoteAndReplyButton extends MessageActionSheetMenuItemButton {
 
   @override get icon => Icons.format_quote_outlined;
 
-  @override get label => 'Quote and reply';
+  @override get translateLabel => (ZulipLocalizations zulipLocalizations) {
+    return zulipLocalizations.actionSheetQuoteAndReply;
+  };
 
   @override get onPressed => (BuildContext bottomSheetContext) async {
     // Close the message action sheet. We'll show the request progress
     // in the compose-box content input with a "[Quoting…]" placeholder.
     Navigator.of(bottomSheetContext).pop();
+    final zulipLocalizations = ZulipLocalizations.of(messageListContext);
 
     // This will be null only if the compose box disappeared after the
     // message action sheet opened, and before "Quote and reply" was pressed.
@@ -174,7 +182,7 @@ class QuoteAndReplyButton extends MessageActionSheetMenuItemButton {
     final rawContent = await fetchRawContentWithFeedback(
       context: messageListContext,
       messageId: message.id,
-      errorDialogTitle: 'Quotation failed',
+      errorDialogTitle: zulipLocalizations.actionSheetQuotationFailed,
     );
 
     if (!messageListContext.mounted) return;
@@ -203,26 +211,29 @@ class CopyButton extends MessageActionSheetMenuItemButton {
 
   @override get icon => Icons.copy;
 
-  @override get label => 'Copy message text';
+  @override get translateLabel => (ZulipLocalizations zulipLocalizations) {
+    return zulipLocalizations.actionSheetCopyMessageText;
+  };
 
   @override get onPressed => (BuildContext context) async {
     // Close the message action sheet. We won't be showing request progress,
     // but hopefully it won't take long at all, and
     // fetchRawContentWithFeedback has a TODO for giving feedback if it does.
     Navigator.of(context).pop();
+    final zulipLocalizations = ZulipLocalizations.of(messageListContext);
 
     final rawContent = await fetchRawContentWithFeedback(
       context: messageListContext,
       messageId: message.id,
-      errorDialogTitle: 'Copying failed',
+      errorDialogTitle: zulipLocalizations.actionSheetCopyingFailed,
     );
 
     if (rawContent == null) return;
 
     if (!messageListContext.mounted) return;
 
-    // TODO(i18n)
-    copyWithPopup(context: context, successContent: const Text('Message copied'),
+    copyWithPopup(context: context,
+      successContent: Text(zulipLocalizations.actionSheetMessageCopied),
       data: ClipboardData(text: rawContent));
   };
 }

test/widgets/action_sheet_test.dart

@@ -1,6 +1,7 @@
 import 'package:checks/checks.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
+import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:zulip/api/model/model.dart';
 import 'package:zulip/api/route/messages.dart';
@@ -48,6 +49,8 @@ Future<void> setupToMessageActionSheet(WidgetTester tester, {
 
   await tester.pumpWidget(
     MaterialApp(
+      localizationsDelegates: ZulipLocalizations.localizationsDelegates,
+      supportedLocales: ZulipLocalizations.supportedLocales,
       home: GlobalStoreWidget(
         child: PerAccountStoreWidget(
           accountId: eg.selfAccount.id,