Skip to content

Commit fda6bac

Browse files
committed
compose [nfc]: Remove obsoleted TODO(#720)s
Issue #720 is superseded by #1441, and these don't apply... I guess with the exception of a note on how a generic "x" button could be laid out, so we leave that.
1 parent 23f1119 commit fda6bac

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

lib/widgets/compose_box.dart

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1290,9 +1290,6 @@ class _SendButtonState extends State<_SendButton> {
12901290
controller.content.clear();
12911291

12921292
try {
1293-
// TODO(#720) clear content input only on success response;
1294-
// while waiting, put input(s) and send button into a disabled
1295-
// "working on it" state (letting input text be selected for copying).
12961293
await store.sendMessage(destination: widget.getDestination(), content: content);
12971294
} on ApiRequestException catch (e) {
12981295
if (!mounted) return;
@@ -1384,7 +1381,6 @@ class _ComposeBoxContainer extends StatelessWidget {
13841381
border: Border(top: BorderSide(color: designVariables.borderBar)),
13851382
boxShadow: ComposeBoxTheme.of(context).boxShadow,
13861383
),
1387-
// TODO(#720) try a Stack for the overlaid linear progress indicator
13881384
child: Material(
13891385
color: designVariables.composeBoxBg,
13901386
child: Column(
@@ -1742,10 +1738,10 @@ class _ErrorBanner extends _Banner {
17421738

17431739
@override
17441740
Widget? buildTrailing(context) {
1745-
// TODO(#720) "x" button goes here.
1746-
// 24px square with 8px touchable padding in all directions?
1747-
// and `bool get padEnd => false`; see Figma:
1748-
// https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4031-17029&m=dev
1741+
// An "x" button can go here.
1742+
// 24px square with 8px touchable padding in all directions?
1743+
// and `bool get padEnd => false`; see Figma:
1744+
// https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4031-17029&m=dev
17491745
return null;
17501746
}
17511747
}
@@ -2083,11 +2079,6 @@ class _ComposeBoxState extends State<ComposeBox> with PerAccountStoreAwareStateM
20832079
}
20842080
}
20852081

2086-
// TODO(#720) dismissable message-send error, maybe something like:
2087-
// if (controller.sendMessageError.value != null) {
2088-
// errorBanner = _ErrorBanner(label:
2089-
// ZulipLocalizations.of(context).errorSendMessageTimeout);
2090-
// }
20912082
return ComposeBoxInheritedWidget.fromComposeBoxState(this,
20922083
child: _ComposeBoxContainer(body: body, banner: banner));
20932084
}

0 commit comments

Comments
 (0)