fix: Advanced orchestration defines global variables and assigns them through assignment nodes. If there is a form collection node before the reference node, the assignment node becomes invalid and the initial variable value is still referenced #3108
Conversation
… through assignment nodes. If there is a form collection node before the reference node, the assignment node becomes invalid and the initial variable value is still referenced
| @@ -45,6 +45,8 @@ def save_context(self, details, workflow_manage): | |||
| self.err_message = details.get('err_message') | |||
| for key, value in workflow_variable.items(): | |||
| workflow_manage.context[key] = value | |||
| for item in details.get('global_fields', []): | |||
| workflow_manage.context[item.get('key')] = item.get('value') | |||
|
|
|||
| def get_node_params_serializer_class(self) -> Type[serializers.Serializer]: | |||
| pass | |||
There was a problem hiding this comment.
There are no notable issues or optimizations in the given code. The function save_context updates a context dictionary based on the inputs and then proceeds to handle global fields if they exist in the input dictionary. However, the documentation provided is not complete; you should include method docstrings for all functions (like get_node_params_serializer_class) that do not have them yet.
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fix: Advanced orchestration defines global variables and assigns them through assignment nodes. If there is a form collection node before the reference node, the assignment node becomes invalid and the initial variable value is still referenced