Skip to content

Allow CreateChatCompletionRequests to be deserialized #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

JonnyLoughlin
Copy link
Contributor

CreateChatCompletionRequests can be serialized and written to output. By deriving Deserialize on the following enums/structs, output can be serialized to a file then read and deserialized to allow continuing of conversations.

PS: This is my first attempt at contributing to an open source project. Please let me know if I went about anything wrong and I apologize if if this was not the proper way to go about this. Thank you for the library!

@64bit
Copy link
Owner

64bit commented Mar 11, 2023

Hi @JLWhitney97 , thank you for choosing async-openai to be your first open source contribution!

"No one can be wrong about their own lived experiences - Aaron Turon, Former Member, Rust Core Team" -
https://youtu.be/dTktT8y8niw?t=750

You did good, nothing to apologize for :)


To serialize and deserialize chat to continue conversation is very cool idea. Lets ship this!

@64bit 64bit merged commit e70220e into 64bit:main Mar 11, 2023
@64bit
Copy link
Owner

64bit commented Mar 11, 2023

Its released in v0.9.3 🎉

dmweis pushed a commit to dmweis/async-openai that referenced this pull request Mar 11, 2023
@JonnyLoughlin
Copy link
Contributor Author

Thank you so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants