Add SocketAddress-based API and deprecate string-based one #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of mbed-os-5.15 the string-based APIs are deprecated. This commit adds the deprecation warning and introduces the new SocketAddress-based API.
|
Hi, @d-kato and @MarceloSalazar , are you the owners of the repository? Could you let me know if this PR is OK and who can merge it? |
|
LGTM! As a side note - added the following to the description of https://github.com/d-kato/esp32-driver. Also, please let me know if you want to add to README.md. |
d-kato
approved these changes
Dec 18, 2019
toyowata
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of mbed-os-5.15 the string-based APIs are deprecated.
This PR adds the deprecation warning and introduces the new SocketAddress-based API.
@d-kato , @toyowata , @0xc0170 , @AnttiKauppila please review.
Please, also note, that as of mbed-os-6.0 the string-based API will be completely removed.
As a side note - could we add some information in https://github.com/d-kato/esp32-driver repository, explaining that it is no longer maintained and has been moved to ARMmbed? @d-kato ?