AT firmware >= 1.7.0 - treat data as OOB #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeppoTakalo
reviewed
Oct 31, 2018
| } else if (!_parser.recv("%d:", &amount)) { | ||
| return; | ||
| } | ||
|
|
||
| pdu_len = sizeof(struct packet) + amount; | ||
|
|
||
| if ((_heap_usage + pdu_len) > MBED_CONF_ESP8266_SOCKET_BUFSIZE) { | ||
| MBED_WARNING(MBED_MAKE_ERROR(MBED_MODULE_DRIVER, MBED_ERROR_CODE_ENOBUFS), \ | ||
| "ESP8266::_packet_handler(): \"esp8266.socket-bufsize\"-limit exceeded, packet dropped"); | ||
| tr_debug("\"esp8266.socket-bufsize\"-limit exceeded, packet dropped"); |
There was a problem hiding this comment.
Why these have been changed from MBED_WARNING to tr_debug()
There was a problem hiding this comment.
Based on @kjbracey-arm's comment about usage of MBED_WARNING.
VeijoPesonen
force-pushed
the
refactor-tcp_passive_data_as_oob
branch
from
32f8d11 to
dedb846
Compare
VeijoPesonen
force-pushed
the
refactor-tcp_passive_data_as_oob
branch
from
dedb846 to
e3aa71f
Compare
Test resultsConclusions
|
SeppoTakalo
approved these changes
Nov 1, 2018
When trying to pull data from the ESP8266 handle it as OOB to prevent timeouts.
VeijoPesonen
force-pushed
the
refactor-tcp_passive_data_as_oob
branch
from
e3aa71f to
7cd0a99
Compare
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid AT recv() timeouts receiving data is handled as OOB.
To get the performance improvement PR ARMmbed/mbed-os#8598 needs to be also taken into use