Include "mbed.h" instead of directly network related headers. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geky
approved these changes
Oct 4, 2016
|
This looks great 👍 I will merge once we have decided the branching model for mbed-os related examples/libraries to avoid hurting user experience. |
|
@geky This is now blocking mbed-os-example-client which is now not compiling on top of mbed OS with new file structure. |
|
It looks like we will be looking at support for a "latest" branch to avoid issues such as #7. I'll go ahead an merge this so dependent projects are unblocked. |
|
Actually, I didn't realize at first, but adopting mbed.h doesn't impact the existing release... Sorry about the delay then... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This driver does not build anymore against mbed OS master.
Quick workaround is to include "mbed.h" header instead of those specific network headers.