Check for socket handle on each socket call #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2018 10:36
Return NSAPI_ERROR_NO_SOCKET if invalid handle. Don't care about ESP8266 complaining about missing socket when closing.
jarlamsa
reviewed
Jun 7, 2018
| @@ -547,6 +560,14 @@ void ESP8266::_connect_error_handler() | |||
| } | |||
| } | |||
|
|
|||
| void ESP8266::_oob_socket_close_error() | |||
| { | |||
| if (_parser.recv("ERROR\n")) { | |||
There was a problem hiding this comment.
If the OOB is "UNLINK ERROR", but triggers with "UNLINK", should you be including also the space somewhere?
There was a problem hiding this comment.
Those two words are actually on two separate lines
SeppoTakalo
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for socket handle on each socket call.
Ignore errors about already closed socket from ESP8266 side and return success. Failure is reported if handle does not exist anymore.
Revealing the timeout values to higher layers is a remnant of changes I haven't included to this PR yet. Those might or might not come later.