Recent versions of ESP8266 do not send OK anymore after reading the stream after IPD #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified against Espressif SDK 1.1 and Espressif SDK 2.0 |
|
This is a very nice patch! Thanks for taking to time to add support for the 2.0 sdk. I want to test locally for sanity, but otherwise it looks good 👍 |
|
Looks good with SDK 0.2 as well, thanks for the patch |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #8. Recent versions (at least since the last year) of Espressif firmware do not send an OK anymore after reading the stream after getting an +IPD message.
With this patch I can run mbed-client on my recently Wifi3 Click.
Need to verify that this still works on old versions of Espressif.
@sg- @gecky