option to pass I2C object #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geky
reviewed
Jun 18, 2018
I2CEEBlockDevice.cpp
Outdated
| @@ -21,11 +21,26 @@ | |||
| I2CEEBlockDevice::I2CEEBlockDevice( | |||
| PinName sda, PinName scl, uint8_t addr, | |||
| bd_size_t size, bd_size_t block, int freq) | |||
| : _i2c(sda, scl), _i2c_addr(addr), _size(size), _block(block) | |||
| : _i2c_p(new I2C(sda, scl)), _i2c(*_i2c_p), _i2c_addr(addr), | |||
There was a problem hiding this comment.
Could you instead use placement new? That way the class still uses the memory needed for the I2C object and we don't have to rely on dynamic memory:
uint32_t _i2c_buffer[sizeof(I2C) / sizeof(uint32_t);
I2C *_i2c;
_i2c = new (_i2c_buffer) I2C(sda, scl);
_i2c->~I2C(); // note needs manual delete
|
I don't understand the |
|
can this be merged? |
|
@pilotak Oh sorry! This needs to be using placement new so static memory errors get caught at compile time. Mind if I modify your pr? |
geky
reviewed
Jul 25, 2018
I2CEEBlockDevice.h
Outdated
| * @param freq The frequency of the I2C bus, defaults to 400K. | ||
| */ | ||
| I2CEEBlockDevice( | ||
| I2C &i2c_obj, uint8_t address, |
There was a problem hiding this comment.
nit: Using a pointer here would make it clear the I2C object is being borrowed.
|
Oh you're fast. I added the placement new change. @pilotak does this look good to you? |
|
that's perfect, this way you can actually see how much space it takes during compile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to pass I2C object