add missing get_type() from BlockDevice #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@geky CI fails because of |
|
Without this fix under the upgraded mbed-os lib I had an error "Error: Variable type 'I2CEEBlockDevice' is an abstract class". |
|
Trying to get the CI green but it's being a pain, seems like the last time CI ran was a year ago... |
- Needed new gcc-arm-embedded ppa - dist: Trusty did not allow apt-get update to work - test.py is no longer working as it once was - Needed to update pip versions
|
Ok, got it working. Thanks for the PR, sorry it took so long for me to get to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to this page it should have a function
get_type()but i think this repo should be merged into OS as all other blockdevices are andI2CEEreturn should be added to above page as well